Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test little things #60

Closed
wants to merge 4 commits into from
Closed

Test little things #60

wants to merge 4 commits into from

Conversation

mkristian
Copy link
Member

No description provided.

this allows to replace certain Ciphers and Signatures with different
implementations other than what comes with BouncyCastle or JCE.

Sponsored by Lookout Inc.
@mkristian
Copy link
Member Author

@kares please have a look at those "little" changes. this SecurityHelper from here is the one which get used by https://github.com/lookout/fast-rsa-engine/blob/master/src/main/java/org/jruby/ext/openssl/SecurityHelper.java

so all those changes would help to inject ciphers to be used by jruby-openssl, i.e. fast-rsa-engine would not need to load certain java classes first (kind of monkey patching the java way)

the extra reflection might be even useful for general cases (oracle-jdk)

@kares
Copy link
Member

kares commented Aug 6, 2015

honestly I wished to be removing parts of SecurityHelper not add more :) as it was introduced as an ugly hack - the motivation was to allow to roll without the crazy 'thing' of self-installing BC as a provider.

must say I was little eager for the merge - now I see room for the fast-rsa gem to exist on its own (at least for a while) ... if you really need the changes go for it, but please try not to push them too far. these public methods on "helpers" (we do not use directly) need at least some javadoc so they're not removed easily: 5576159 ... also if the fake classes had a note and maybe a license on top that would be great. thanks!

@mkristian mkristian closed this Oct 6, 2015
@mkristian mkristian deleted the test-little-things branch October 6, 2015 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants