this seems correct to me, @jbenet @Luzifer ?

Hadn't time to test yet but either it makes things better or it doesn't change things. So no negative results expected. LGTM

would be good to have a sharness test that tests the Dockerfile

test it by running a docker image with the file?

yep!

On Friday, October 9, 2015, Jeromy Johnson notifications@github.com wrote:

test it by running a docker image with the file?

—
Reply to this email directly or view it on GitHub
#1806 (comment).

are we saying that a test on the dockerfile is a hard requirement for this PR?

Well We should confirm it works, and that it be broken again. If not now, when?

just clarifying so we know what tasks need to be done before this PR can merge.

@ChristianKniep are you familiar with our sharness testing and would you have time to do this?

else, is anyone else able to?

continued in #2064