Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubinius/rubinius
base: 407245534ed4
Choose a base ref
...
head repository: rubinius/rubinius
compare: b9e090712eac
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 3, 2015

  1. fix bug in spec where incorrect args were passed to test #gets with l…

    …imit
    
    Tricky one to find. The original spec used #gets(1) to read one
    char. Unfortunately, this arg format ends up setting a separator
    to $/ so the logic ends up calling
    EachReader#read_to_separator_with_limit instead of
    EachReader#read_to_limit. By passing nil, as in #gets(nil, 1),
    then we force the code paths to call read_to_limit.
    chuckremes committed Oct 3, 2015
    Copy the full SHA
    1cf5d4a View commit details
    Browse the repository at this point in the history
  2. fix handling of multi-byte chars when reading with char limits

    This fixes several specs shared by gets, foreach, and readline.
    The EachReader class needs a good refactoring at this point
    but for now I just want to commit working code.
    chuckremes committed Oct 3, 2015
    Copy the full SHA
    b9e0907 View commit details
    Browse the repository at this point in the history