Test messages #18
Merged
Test messages #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would have liked to have documented the different outputs of the t_test functions by more than just their variable names, but I couldn't find any documentation on what they actually are.
|
Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my pet peeves is tests with no messages. I saw you had even put some comments in the test files such as
Having unique test messages for every test makes that sort of thing unnecessary :-)
I also learned a lot about what possible things PDL::Stats can do so it was a good time for me even if you don't merge this. I'm sure I've written PDL::Stats::TS::fill_ma before when I should've just reached for PDL.