[Truffle] Fixed error checking order in String#downcase! to match MRI.

jruby · Sep 28, 2015 · bfa7d6c · bfa7d6c · eregon · Sep 28, 2015
1 parent b271fc7
commit bfa7d6c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java
@@ -957,17 +957,17 @@ public DynamicObject downcase(DynamicObject string) {
             final ByteList bytes = codeRangeable.getByteList();
             final Encoding encoding = bytes.getEncoding();
 
-            if (bytes.realSize() == 0) {
-                return nil();
-            }
-
             if (encoding.isDummy()) {
                 CompilerDirectives.transferToInterpreter();
                 throw new RaiseException(
                         getContext().getCoreLibrary().encodingCompatibilityError(
                                 String.format("incompatible encoding with this operation: %s", encoding), this));
             }
 
+            if (bytes.realSize() == 0) {
+                return nil();
+            }
+
             codeRangeable.modifyAndKeepCodeRange();
 
             final boolean modified = StringSupport.multiByteDowncase(encoding, bytes.unsafeBytes(), bytes.begin(), bytes.realSize());