-
-
Notifications
You must be signed in to change notification settings - Fork 925
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b799bfff8df5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e9d5c9489262
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 3 commits
- 6 files changed
- 1 contributor
Commits on Oct 5, 2015
-
Enum#values is a new array every time, so avoid it for Visibility.
Several places used Visibility.values to get a list of all Visibilities, with the result that they created a new array every time. There may be other enums with the same usage but they have not shown up in my profiles.
Configuration menu - View commit details
-
Copy full SHA for b33d760 - Browse repository at this point
Copy the full SHA b33d760View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52ab58d - Browse repository at this point
Copy the full SHA 52ab58dView commit details -
Share evalType threadlocal between mixed mode and compiled block.
Fixes #3368 evalType gets tweaked at various stages of block execution, and when there were two copies in MixedModeIRBlockBody and its contained CompiledIRBlockBody, they weren't being set consistently in both places. This change makes them share the threadlocal and fixes the issues in #3368 leading to eval not scoping right. The root problem was that evalType is used to indicate that a given body is being used for an eval, which in this case meant it was being used for a Class.new class eval. Without the flag, the search for a method def scope would walk past the Class.new block and out into the containing class, defining methods in the wrong place. TODO: Clean up state like evalType and do a better job of unifying the different container objects for block bodies.
Configuration menu - View commit details
-
Copy full SHA for e9d5c94 - Browse repository at this point
Copy the full SHA e9d5c94View commit details
There are no files selected for viewing