-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdlib: TCPServer#shutdown raises ENOTCONN #2240
Comments
Any update on this? Will it make it's way into 9k? I know it's nothing MAJOR but seems nice to fix :) |
I'm getting |
Still happening for me:
Maybe cause I'm on Linux?
|
also still happening on JRuby (sorry had to fixup my JRuby install after some asdf problems):
|
@PragTob I checked on Linux and yes, CRuby behaves differently on Linux and macOS. On macOS behavior is the same as on JRuby. So I feel confused about what behaviour is expected. |
I guess this would be a bug for CRuby itself then, in which they can figure out what the correct behavior is. I tend to think no error is correct but who am I to tell? :) |
@PragTob I investigated this a little bit more and wanna say that this is completely legal to return |
@etehtsea see the initial issue report:
Sadly I don't have access to the application anymore, as it was a code challenge in a private github repo and I don't pay for github :D That said the goal of JRuby is to be CRuby compatible so I think it should do the same. With CRuby being inconsistent it might be worthwhile to ask them though |
@PragTob uhmm. This is strange that you had issues with
@headius am I right? |
@etehtsea Yes, I would say you are right. We do stretch to try to emulate CRuby on a "bug-for-bug basis" but asking to shut down a socket that's not connected seems like a bridge too far. This is also very old now, so I'm going to call it stale and mark it Won't Fix. |
Hi everyone :)
So I've been implementing some TCPServer stuff and I noticed an oddity/incompatibility between JRuby (1.7.16.1) and CRuby (2.1.5). Take this simple script:
It runs just fine on CRuby, as I'd expect but it raises
ENOTCONN
on JRuby:Errno::ENOTCONN: Transport endpoint is not connected - Socket is not connected
Just checked jruby-head - it's also broken there.
That's a pity right now, as that's why my test suite fails for JRuby. Funnily changing shutdown to close (in my test suite, not this example script) works for JRuby but then CRuby fails... :-/
Thanks for JRuby :)
Tobi
The text was updated successfully, but these errors were encountered: