Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for Python 2 #2129

Merged
merged 12 commits into from Oct 4, 2015
Merged

Deprecation warning for Python 2 #2129

merged 12 commits into from Oct 4, 2015

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Oct 1, 2015

No description provided.

PY2_WARNING = """Nikola is going to deprecate python 2 support in 2016. You already have python 3
available in your system. Why not switch?

Please check https://getnikola.com/blog/env-survey-results-and-the-future-of-python-27.html for details."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use a shorter link.

Also, Python* should be uppercase

@@ -64,6 +64,25 @@
# DO NOT USE unless you know what you are doing!
_RETURN_DOITNIKOLA = False

PY2_WARNING = """Nikola is going to deprecate Python 2 support in 2016. You already have Python 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You most likely have Python 3 available on your system already! (And if you don’t, you can install it really easily.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually intended to check if it's available, and use a different message if it's not.

@ralsina ralsina changed the title WIP Deprecation warning for Python 2 Deprecation warning for Python 2 Oct 3, 2015
PY2_WARNING = """Nikola is going to deprecate Python 2 support in 2016. You already have Python 3
available in your system. Why not switch?

Please check http://bit.ly/1FKEsiX for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid shortened URL here. People will copy-past anyway, and you never know if bit.ly will keep it infinitely.
If you keep it you can probably make a custom name like bit.ly/drop-Python-2 which is easier to remember.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worst case scenario, we could create a redirect on getnikola.com/py2 (probably via nginx config, not conf.REDIRECTIONS) and use that.

ralsina added a commit that referenced this pull request Oct 4, 2015
@ralsina ralsina merged commit 4c7367a into master Oct 4, 2015
@ralsina ralsina deleted the fight-the-future branch October 4, 2015 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants