Revert "Don't throw error when using db_fetch_array on empty resultset"

dregad · dregad · commit a12d6b7cc8c4 · 2012-06-04T13:26:38.000+02:00
As per grangeway's comment and confirmed by vincent_sels (original issue's reporter), this change is actually not necessary. This reverts commit 33170d2. Affects #14336
diff --git a/core/database_api.php b/core/database_api.php
@@ -427,7 +427,7 @@ function db_affected_rows() {
 function db_fetch_array( &$p_result ) {
 	global $g_db, $g_db_type;
 
-	if( is_null( $p_result ) || $p_result->EOF ) {
+	if( $p_result->EOF ) {
 		return false;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,7 @@ function db_affected_rows() {`
`427`	`427`	`function db_fetch_array( &$p_result ) {`
`428`	`428`	`global $g_db, $g_db_type;`
`429`	`429`
`430`		`- if( is_null( $p_result ) \|\| $p_result->EOF ) {`
	`430`	`+ if( $p_result->EOF ) {`
`431`	`431`	`return false;`
`432`	`432`	`}`
`433`	`433`