Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: d904c231b6f5
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 8ce02cf0aa21
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jul 23, 2013

  1. buffer: revert length and parent check

    In a rush to implement the fix 35e0d60 I overlooked the logic that
    causes 0-length buffer instantiation to automatically not assign the
    parent regardless.
    trevnorris committed Jul 23, 2013
    Copy the full SHA
    d74932e View commit details
    Browse the repository at this point in the history
  2. buffer: misc logic simplification

    Includes:
    * No need for `typeof` when checking undefined.
    * length is coerced to uint so no need to check if < 0.
    * Stay consistent and always throw `new` errors.
    * Returning offset + magic number in every write is error prone. Instead
      return the central write function which returns the correct offset.
    trevnorris committed Jul 23, 2013
    1
    Copy the full SHA
    8ce02cf View commit details
    Browse the repository at this point in the history