add a warning if the optional PGPLOT dependency is not available #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still dies if PGPLOT is not installed because optional dependencies can be skipped at installation, but gives users a clear notification of why their code will not load. Mithaldu++ for bringing up the issue on the #pdl IRC <http://irclog.perlgeek.de/pdl/2015-09-15#i_11219756>.
mohawk2
force-pushed
the
pgplot-dep-warn
branch
from
67a48ac
to
5493eab
Compare
|
I've updated this to still die, else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warns if PGPLOT is missing when is not installed because optional
dependencies can be skipped at installation. This gives users a clear
notification of why their code will not load.
Mithaldu++ for bringing up the issue on the #pdl IRC
http://irclog.perlgeek.de/pdl/2015-09-15#i_11219756.
CC: @wchristian
Branch note: This branch is a WIP. It still needs tests and Travis-CI support. Anyone else is welcome to move it forward.