-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Book tutorial #30
Book tutorial #30
Conversation
|
||
But sometimes, you don't want to do the same thing you have been doing. Sometimes you | ||
want to make a one-off, a special thing, and Nikola should not get in the way | ||
of you doing that, either, and should let you get your hands as dirty as you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/, either, and/. Rather, it/
@Kwpolska done, care to take a final look for wording and that kind of thing? |
.chapter { | ||
width: 100%; | ||
padding: 10px; | ||
-webkit-column-gap: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t we add prefixless column-*
properties for other browsers? How does this work in Firefox?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know! Let's see...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works ... HORRIBLY! Ok, I'll add the other variants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
And you know what happened? I fixed the bugs, and I will implement the feature request! And if you try to do | ||
cool crazy stuff with Nikola, you will find bugs, and will ask for features, and there is a pretty good | ||
chance we will fix them, or find workarounds. After all we have already done it at least | ||
`1179 times. <https://github.com/getnikola/nikola/issues?q=is%3Aissue+is%3Aclosed>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the number (1,188
), or make it 2,011
and include pull requests (which might make some sense)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that number is never going to be fixed, and PRs is cheating, because we often have PRs for a bug report :-)
👍 |
Do not merge until I rewrite it. On reading it after sleeping on it, I don't like some things in it. I will move a bunch of the descriptions to comments in the templates, and trim the listings to show only the most relevant parts. It's a minor rewrite, and I should be able to do it tonight, or tomorrow night.
Do not merge until typogrify works properly with the final version of the template using nikola from master.Things to fix: