Skip to content

Commit

Permalink
dots are ignored earlier now
Browse files Browse the repository at this point in the history
  • Loading branch information
kraih committed Sep 12, 2015
1 parent 3ca46ad commit 1a16400
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 38 deletions.
1 change: 0 additions & 1 deletion lib/Mojo/UserAgent/CookieJar.pm
Expand Up @@ -23,7 +23,6 @@ sub add {
# Replace cookie
my $origin = $cookie->origin // '';
next unless my $domain = lc($cookie->domain // $origin);
$domain =~ s/^\.//;
next unless my $path = $cookie->path;
next if (my $name = $cookie->name // '') eq '';
my $jar = $self->{jar}{$domain} ||= [];
Expand Down
37 changes: 0 additions & 37 deletions t/mojo/cookiejar.t
Expand Up @@ -211,43 +211,6 @@ is $cookies->[0]->name, 'foo', 'right name';
is $cookies->[0]->value, 'bar', 'right value';
is $cookies->[1], undef, 'no second cookie';

# Ignore leading dot
$jar = Mojo::UserAgent::CookieJar->new;
$jar->add(
Mojo::Cookie::Response->new(
domain => '.example.com',
path => '/foo',
name => 'foo',
value => 'bar'
),
Mojo::Cookie::Response->new(
domain => 'example.com',
path => '/foo',
name => 'bar',
value => 'baz'
)
);
$cookies = $jar->find(Mojo::URL->new('http://www.labs.example.com/foo'));
is $cookies->[0]->name, 'foo', 'right name';
is $cookies->[0]->value, 'bar', 'right value';
is $cookies->[1]->name, 'bar', 'right name';
is $cookies->[1]->value, 'baz', 'right value';
is $cookies->[2], undef, 'no third cookie';
$cookies = $jar->find(Mojo::URL->new('http://labs.example.com/foo'));
is $cookies->[0]->name, 'foo', 'right name';
is $cookies->[0]->value, 'bar', 'right value';
is $cookies->[1]->name, 'bar', 'right name';
is $cookies->[1]->value, 'baz', 'right value';
is $cookies->[2], undef, 'no third cookie';
$cookies = $jar->find(Mojo::URL->new('http://example.com/foo/bar'));
is $cookies->[0]->name, 'foo', 'right name';
is $cookies->[0]->value, 'bar', 'right value';
is $cookies->[1]->name, 'bar', 'right name';
is $cookies->[1]->value, 'baz', 'right value';
is $cookies->[2], undef, 'no third cookie';
$cookies = $jar->find(Mojo::URL->new('http://example.com/foobar'));
is $cookies->[0], undef, 'no cookies';

# "(" in path
$jar = Mojo::UserAgent::CookieJar->new;
$jar->add(
Expand Down

0 comments on commit 1a16400

Please sign in to comment.