[Truffle] Implement objspace. #3321

chrisseaton · 2015-09-11T18:15:43Z

Not massively useful I'll admit, but we can actually implement most of the methods here with something useful. If someone has a tool that uses objspace I would imagine it would display some useful stuff.

In some cases like allocation tracing we can actually implement that without problem.

In some other cases I've translated features to Truffle. For example #count_nodes normally reports MRI AST node names, but I'm reporting Truffle node names, which is actually quite an interesting thing to see.

{:NODE_SCOPE=>596, :NODE_BLOCK=>1604, :NODE_IF=>324, :NODE_CASE=>16, :NODE_WHEN=>64, :NODE_WHILE=>7, :NODE_UNTIL=>1, :NODE_ITER=>161, :NODE_BREAK=>1, :NODE_NEXT=>15, :NODE_BEGIN=>37, :NODE_RESCUE=>15, :NODE_RESBODY=>16, :NODE_ENSURE=>5, :NODE_AND=>72, :NODE_OR=>36, :NODE_MASGN=>14, :NODE_LASGN=>202, :NODE_DASGN=>2, :NODE_DASGN_CURR=>60, :NODE_IASGN=>211, :NODE_CDECL=>30, :NODE_CVASGN=>18, :NODE_OP_ASGN1=>5, :NODE_OP_ASGN2=>2, :NODE_OP_ASGN_OR=>66, :NODE_CALL=>1489, :NODE_FCALL=>333, :NODE_VCALL=>262, :NODE_SUPER=>9, :NODE_ZSUPER=>12, :NODE_ARRAY=>2481, :NODE_ZARRAY=>46, :NODE_HASH=>22, :NODE_RETURN=>71, :NODE_YIELD=>12, :NODE_LVAR=>688, :NODE_DVAR=>520, :NODE_GVAR=>9, :NODE_IVAR=>261, :NODE_CONST=>602, :NODE_CVAR=>27, :NODE_NTH_REF=>33, :NODE_BACK_REF=>1, :NODE_MATCH2=>3, :NODE_MATCH3=>12, :NODE_LIT=>419, :NODE_STR=>857, :NODE_DSTR=>136, :NODE_EVSTR=>218, :NODE_DREGX=>4, :NODE_ARGS=>526, :NODE_ARGS_AUX=>88, :NODE_OPT_ARG=>25, :NODE_ARGSCAT=>13, :NODE_SPLAT=>2, :NODE_BLOCK_PASS=>10, :NODE_DEFN=>251, :NODE_DEFS=>118, :NODE_ALIAS=>16, :NODE_CLASS=>39, :NODE_MODULE=>5, :NODE_SCLASS=>2, :NODE_COLON2=>316, :NODE_COLON3=>5, :NODE_CREF=>522, :NODE_DOT2=>1, :NODE_SELF=>194, :NODE_NIL=>107, :NODE_TRUE=>27, :NODE_FALSE=>29, :NODE_ERRINFO=>4, :NODE_DEFINED=>23, :NODE_MEMO=>5, :NODE_IFUNC=>5, :NODE_DSYM=>1, :NODE_ATTRASGN=>104}

{:RubyRootNode=>3800, :ExceptionTranslatingNode=>3824, :SequenceNode=>4342, :CheckArityNode=>3748, :AllocateConstructorNodeGen=>1, :SelfNode=>3658, :InheritedNodeGen=>279, :InitializeNodeGen=>634, :ClassExecNodeGen=>355, :YieldDispatchHeadNode=>390, :CallBlockNodeGen=>390, :CallBlockNode_=>357, :UninitializedNode_=>28572, :CallNodeWrapperNode=>357, :DefaultDirectCallNode=>1046, :ClassExec0Node_=>355, :Initialize1Node_=>634, :CallDispatchHeadNode=>13492, :CachedSingletonDispatchNode=>440, :UnresolvedDispatchNode=>13495, :ReadPreArgumentNode=>2942, :ReadBlockNode=>463, :PolymorphicNode_=>680, :Initialize3Node_=>279, :CatchRetryAsErrorNode=>1559, :CatchReturnNode=>1558, :WriteLocalVariableNode=>3900, :WriteFrameSlotNodeGen=>3900, :RubyWrapperNode=>6585, :OrNode=>99, :AndNode=>184, :RubyCallNode=>5084, :ReadLocalVariableNode=>5722, :ReadFrameSlotNodeGen=>5722, :BooleanCastNodeGen=>7016, :IntegerFixnumLiteralNode=>541, :ProbeNode=>6585, :IfNode=>1383, :WriteObjectNode_=>350, :NilNode=>1747, :AliasMethodNodeGen=>76, :NameToJavaStringNodeGen=>1216, :CoerceRubySymbolNode_=>988, :UninitialisedArrayLiteralNode=>240, :LiteralNode=>2495, :PrivateNodeGen=>76, :SetVisibilityNodeGen=>304, :SetMethodVisibilityNodeGen=>304, :SingletonClassNodeGen=>393, :ReadRemainingArgumentsNode=>773, :ReadLiteralConstantNode=>1001, :ReadConstantNode=>1001, :LookupConstantNodeGen=>1001, :GetConstantNodeGen=>2468, :StringLiteralNode=>937, :PrependFeaturesNodeGen=>76, :TaintResultNode=>156, :IsTaintedNodeGen=>427, :UndefMethodNodeGen=>76, :RaiseIfFrozenNode=>188, :IsFrozenNodeGen=>341, :IsFrozen5Node_=>236, :ReadHeadObjectFieldNodeGen=>427, :ReadObjectFieldCachedNode_=>938, :CachedBoxedDispatchNode=>204, :IncludedNodeGen=>75, :RemoveConstNodeGen=>76, :ModuleFunctionNodeGen=>76, :FreezeNodeGen=>153, :SingletonClassClassNode_=>152, :SingletonClass3Node_=>154, :AttrAccessorNodeGen=>76, :GenerateAccessorNodeGen=>456, :ExtendObjectNodeGen=>76, :InitializeCopyNodeGen=>76, :InitializeCopyModuleNode_=>76, :DefineMethodNodeGen=>76, :DefineMethodBlockNode_=>76, :DefineMethodProcNode_=>76, :DefineMethod1Node_=>76, :RemoveMethodNodeGen=>76, :AttrReaderNodeGen=>76, :ProtectedNodeGen=>76, :PublicNodeGen=>76, :AttrWriterNodeGen=>76, :AttrNodeGen=>76, :AppendFeaturesNodeGen=>76, :IsTainted4Node_=>79, :CatchBreakNode=>425, :WhileNode=>106, :DefaultLoopNode=>106, :WhileRepeatingNode=>104, :ProcOrNullNodeGen=>431, :BlockDefinitionNode=>319, :ReadConstantWithLexicalScopeNode=>1467, :LookupConstantWithLexicalScopeNodeGen=>1467, :ReturnNode=>349, :InterpolatedStringNode=>270, :TaintNodeGen=>270, :ToSNodeGen=>744, :ReadRestArgumentNode=>186, :ProcCastNodeGen=>20, :SplatCastNodeGen=>156, :ArrayDupNodeGen=>156, :AllocateObjectNodeGen=>164, :WriteInstanceVariableNode=>87, :BooleanLiteralNode=>302, :WriteHeadObjectFieldNode=>87, :UninitializedWriteObjectFieldNode=>87, :DefinedWrapperNode=>66, :ElidableResultNode=>36, :ArrayReadNormalizedNodeGen=>67, :TryNode=>43, :ClearExceptionVariableNode=>43, :ThreadLocalObjectNode=>55, :RescueClassesNode=>39, :ReadInstanceVariableNode=>112, :SmallHashLiteralNode=>104, :HashNode=>111, :NotNode=>4, :WriteIntegerNode_=>23, :CallRubiniusPrimitiveNode=>45, :StringFromCodepointPrimitiveNodeGen=>1, :StringFromCodepointSimple0Node_=>1, :StringFromCodepointNode_=>1, :AllocateNodeGen=>18, :LookupConstantNode_=>90, :GetConstantNode_=>88, :ReadObjectNode_=>200, :StringFromByteArrayPrimitiveNodeGen=>1, :FixnumLowerNodeGen=>43, :StringPatternPrimitiveNodeGen=>1, :ReadOptionalArgumentNode=>204, :ClockGetTimeNodeGen=>1, :DefaultValueNodeGen=>1, :PidNodeGen=>1, :VMWaitPidPrimitiveNodeGen=>1, :InvokeRubiniusPrimitiveNode=>5, :UndefinedPrimitiveNodeGen=>4, :TimeNodeGen=>1, :IsRubiniusUndefinedNode=>27, :KillNodeGen=>1, :YieldNode=>31, :TimesNodeGen=>1, :SetMethodDeclarationContext=>3, :AddMethodNode=>10, :MethodDefinitionNode=>10, :ProcNode_=>14, :NilNode_=>22, :GeneralSuperCallNode=>91, :LookupSuperMethodNodeGen=>91, :MetaClassNodeGen=>127, :CallMethodNodeGen=>92, :ExitBangNodeGen=>1, :BlockGivenNodeGen=>2, :StringNodeGen=>1, :FormatNodeGen=>3, :RandNodeGen=>1, :LambdaNodeGen=>1, :AbortNodeGen=>1, :GetsNodeGen=>1, :BindingNodeGen=>1, :AllocateCachedNode_=>5, :DupObjectNode_=>1, :Splat1Node_=>1, :ExecNodeGen=>1, :LoadNodeGen=>1, :MethodNameNodeGen=>1, :ForkNodeGen=>1, :BacktickNodeGen=>1, :CalleeNameNodeGen=>1, :RequireRelativeNodeGen=>1, :RequireNodeGen=>1, :ToPathNodeGen=>1, :ExitNodeGen=>1, :SleepNodeGen=>1, :ArrayConcatNode=>13, :UninitializedArrayBuilderNode=>13, :RangeLiteralNodeGen=>13, :ProcNodeGen=>1, :ProcNewNodeGen=>2, :EmptyHashLiteralNode=>51, :SystemNodeGen=>1, :SetTraceFuncNodeGen=>1, :CallerLocationsNodeGen=>1, :EvalNodeGen=>1, :ToStrNodeGen=>1, :NestingNodeGen=>1, :WriteBooleanNode_=>10, :IntegerFixnumNode_=>7, :ReadIntegerNode_=>49, :CachedUnboxedDispatchNode=>26, :BooleanNode_=>82, :ReadBooleanNode_=>12, :BreakNode=>7, :RescueAnyNode=>9, :IsANodeGen=>36, :NativeFunctionTypeSizePrimitiveNodeGen=>1, :YieldNodeGen=>1, :FiberTransferNodeGen=>1, :InteropToRubyNodeGen=>1, :IsExecutableNodeGen=>1, :ForeignObjectAccessHeadNode=>8, :UnresolvedObjectAccessNode=>8, :ReadPropertyNodeGen=>1, :UnboxValueNodeGen=>1, :IsNullNodeGen=>1, :ExecuteNodeGen=>1, :HasSizePropertyNodeGen=>1, :WritePropertyNodeGen=>1, :GetSizeNodeGen=>1, :IsBoxedPrimitiveNodeGen=>1, :DoWhileRepeatingNode=>2, :WeakRefNewPrimitiveNodeGen=>1, :CRC32NodeGen=>1, :DeflateNodeGen=>1, :InflateNodeGen=>1, :ToS0Node_=>13, :WriteObjectObjectFieldNode=>21, :EnsureNode=>20, :SetDefaultInternalNodeGen=>1, :SetDefaultExternalNodeGen=>1, :ListNodeGen=>2, :CompatibleQueryNodeGen=>1, :EncodingMapNodeGen=>1, :LocaleCharacterMapNodeGen=>1, :DefinedNode=>5, :CachedBooleanDispatchNode=>5, :ConstructNodeGen=>1, :ExceptionErrnoErrorPrimitiveNodeGen=>1, :PointerAllocatePrimitiveNodeGen=>1, :TimeSFromArrayPrimitiveNodeGen=>1, :ReadTimeZoneNode=>3, :TimeSSpecificPrimitiveNodeGen=>1, :TimeSNowPrimitiveNodeGen=>1, :TimeSDupPrimitiveNodeGen=>1, :ErfcNodeGen=>1, :TanNodeGen=>1, :SqrtNodeGen=>1, :CbRtNodeGen=>1, :CosNodeGen=>1, :SinNodeGen=>1, :Log2NodeGen=>1, :ACosHNodeGen=>1, :FrExpNodeGen=>1, :ACosNodeGen=>1, :ATan2NodeGen=>1, :HypotNodeGen=>1, :ATanNodeGen=>1, :LogNodeGen=>1, :CosHNodeGen=>1, :ASinNodeGen=>1, :ExpNodeGen=>1, :ErfNodeGen=>1, :Log10NodeGen=>1, :LGammaNodeGen=>1, :ATanHNodeGen=>1, :GammaNodeGen=>1, :LdexpNodeGen=>1, :SinHNodeGen=>1, :ASinHNodeGen=>1, :TanHNodeGen=>1, :GenericHashLiteralNode=>6, :MainNodeGen=>1, :WriteLongNode_=>4, :ReadLongNode_=>6, :CurrentNodeGen=>1, :PassNodeGen=>1, :RetryNode=>1, :LongFixnumLiteralNode=>1, :SHA384NodeGen=>1, :SHA512NodeGen=>1, :DigestLengthNodeGen=>1, :MD5NodeGen=>1, :SHA256NodeGen=>1, :ResetNodeGen=>1, :BubbleBabbleNodeGen=>1, :DigestNodeGen=>1, :UpdateNodeGen=>1, :SHA1NodeGen=>1, :StringCheckNullSafePrimitiveNodeGen=>1, :VMObjectSingletonClassPrimitiveNodeGen=>1, :SingletonClassMethodNodeGen=>1, :VMObjectKindOfPrimitiveNodeGen=>1, :SingletonClass0Node_=>1, :IsACachedNode_=>6, :VMObjectRespondToPrimitiveNodeGen=>1, :RespondToNodeGen=>1, :DoesRespondDispatchHeadNode=>3, :BooleanCastWithDefaultNodeGen=>1, :ObjectInfectPrimitiveNodeGen=>1, :BasicObjectNode_=>8, :VMSetModuleNamePrimitiveNodeGen=>1, :VMObjectSingletonClassObjectPrimitiveNodeGen=>1, :VMObjectEqualPrimitiveNodeGen=>1, :ReferenceEqualNodeGen=>7, :Equal4Node_=>1, :StringToFPrimitiveNodeGen=>1, :VMObjectClassPrimitiveNodeGen=>1, :ClassNodeGen=>1, :ReadMatchReferenceNode=>3, :EachAncestorNodeGen=>1, :EncodingGetObjectEncodingNodeGen=>1, :VMGetModuleNamePrimitiveNodeGen=>1, :CachedBoxedSymbolDispatchNode=>4, :NewNodeGen=>4, :NewInstance0Node_=>4, :NewInstance1Node_=>4, :EmptyArrayLiteralNode=>5, :ObjectArrayLiteralNode=>3, :ToS1Node_=>2, :StringAwkSplitPrimitiveNodeGen=>1, :AllSymbolsNodeGen=>1, :AdjacentObjectsNodeGen=>1, :TraceAllocationsStopNodeGen=>1, :TraceAllocationsStartNodeGen=>1, :MemsizeOfNodeGen=>1, :RootObjectsNodeGen=>1, :AllocateUncachedNode_=>1, :IOOpenPrimitiveNodeGen=>1, :PushOneNodeGen=>1, :DupNodeGen=>2, :CopyNodeGen=>1, :GetFromThreadLocalNodeGen=>2, :WrapInThreadLocalNodeGen=>1, :IOSelectPrimitiveNodeGen=>1, :IOConnectPipeNodeGen=>1, :IOFNMatchPrimitiveNodeGen=>1, :IOTruncatePrimitiveNodeGen=>1, :IOAllocatePrimitiveNodeGen=>1, :VMGCStartPrimitiveNodeGen=>1, :CatchNodeGen=>1, :VMRaiseExceptionPrimitiveNodeGen=>1, :ThrowNodeGen=>1, :VMGetUserHomePrimitiveNodeGen=>1, :VMWatchSignalPrimitiveNodeGen=>1, :WatchSignalProcNode_=>1, :SetReceiverNode=>5, :DirAllocatePrimitiveNodeGen=>1, :ReadClassVariableNode=>2, :PointerMallocPrimitiveNodeGen=>1, :UpdateVerbosityNode=>2, :SetNodeGen=>3, :LookupEntryNode=>3, :SetBucketsNode_=>2, :SourceOfCallerNodeGen=>2, :BindingOfCallerNodeGen=>2, :RegexpPropagateLastMatchPrimitiveNodeGen=>1, :RegexpSetBlockLastMatchPrimitiveNodeGen=>1, :QuoteNodeGen=>2, :RegexpSetLastMatchPrimitiveNodeGen=>1, :ReadKeywordArgumentNode=>2, :ReturnEnumeratorIfNoBlockNode=>1, :EachObjectNodeGen=>1, :EachObject1Node_=>1, :ID2RefNodeGen=>1, :UndefineFinalizerNodeGen=>1, :DefineFinalizerNodeGen=>1, :RespondToNode=>1, :ChdirNodeGen=>1, :GetGIDNodeGen=>1, :FchownNodeGen=>1, :SocketNodeGen=>1, :MkdirNodeGen=>1, :GetHostNameNodeGen=>1, :SetReuidNodeGen=>1, :SetResuidNodeGen=>1, :SetEuidNodeGen=>1, :SetUidNodeGen=>1, :SetSidNodeGen=>1, :GetUIDNodeGen=>1, :FreeAddrInfoNodeGen=>1, :MemsetNodeGen=>1, :SymlinkNodeGen=>1, :GetSockOptNodeGen=>1, :GetAddrInfoNodeGen=>1, :MajorNodeGen=>1, :RenameNodeGen=>1, :GetPeerNameNodeGen=>1, :SetPriorityNodeGen=>1, :ShutdownNodeGen=>1, :ChmodNodeGen=>1, :FlockNodeGen=>1, :UnlinkNodeGen=>1, :GetcwdNodeGen=>1, :UnsetenvNodeGen=>1, :GetGroupsNodeGen=>1, :ErrnoAssignNodeGen=>1, :AccessNodeGen=>1, :SetgidNodeGen=>1, :LinkNodeGen=>1, :GetppidNodeGen=>1, :ListenNodeGen=>1, :GetPriorityNodeGen=>1, :SetRuidNodeGen=>1, :BindNodeGen=>1, :ReadlinkNodeGen=>1, :SetenvNodeGen=>1, :ChownNodeGen=>1, :GetSockNameNodeGen=>1, :ConnectNodeGen=>1, :IsATTYNodeGen=>1, :MinorNodeGen=>1, :EnvironNodeGen=>1, :SetSockOptNodeGen=>1, :GetRLimitNodeGen=>1, :GetEGIDNodeGen=>1, :RmdirNodeGen=>1, :SetRLimitNodeGen=>1, :UtimesNodeGen=>1, :GetNameInfoNodeGen=>1, :GetpgrpNodeGen=>1, :FsyncNodeGen=>1, :GetEUIDNodeGen=>1, :FchmodNodeGen=>1, :GetpgidNodeGen=>1, :PutenvNodeGen=>1, :GetenvNodeGen=>1, :UmaskNodeGen=>1, :FcntlNodeGen=>1, :Fcntl1Node_=>1, :ErrnoNodeGen=>1, :IOBufferAllocatePrimitiveNodeGen=>1, :VMSetClassPrimitiveNodeGen=>1, :AttachNodeGen=>1, :AssertConstantNodeGen=>1, :JavaClassOfNodeGen=>1, :SimpleShellNodeGen=>1, :GCTimeNodeGen=>1, :GCCountNodeGen=>1, :PrintInterleavedBacktraceNodeGen=>1, :CExtSupportedNodeGen=>1, :DumpStringNodeGen=>1, :DebugPrintNodeGen=>1, :InstallRubiniusPrimitiveNodeGen=>1, :AssertNotCompiledNodeGen=>1, :CoverageStartNodeGen=>1, :CoverageResultNodeGen=>1, :GraalNodeGen=>1, :HostOSNodeGen=>1, :JRubyHomeDirectoryNodeGen=>1, :ASTNodeGen=>1, :AstMethodNode_=>1, :SynchronizedPrimitiveNodeGen=>1, :FixnumLowerPrimitiveNodeGen=>1, :Lower0Node_=>1, :Lower1Node_=>1, :SubstrateNodeGen=>1, :CExtLoadNodeGen=>1, :DetachNodeGen=>1, :AtExitSystemNodeGen=>1, :GraalVersionNodeGen=>1, :CallNodeGen=>1, :NodeArrayToObjectArrayNode=>1, :TranscodingMapNodeGen=>1, :CatchReturnAsErrorNode=>1, :CatchNextNode=>1, :CatchReturnPlaceholderNode=>1, :WriteConstantNode=>19, :LexicalScopeNode=>19, :AliasNodeGen=>1, :Alias0Node_=>1, :SetBucketsNotByIdentityNode_=>1}

@eregon please review

eregon · 2015-09-13T13:12:01Z

truffle/src/main/java/org/jruby/truffle/runtime/subsystems/ObjectSpaceManager.java

@@ -55,6 +58,10 @@ public void clearFinalizers() {
    private final ReferenceQueue<DynamicObject> finalizerQueue = new ReferenceQueue<>();
    private DynamicObject finalizerThread;

+    private final CyclicAssumption tracingAssumption = new CyclicAssumption("objspec-tracing");


objspace-tracing I suppose?

eregon · 2015-09-14T09:56:39Z

lib/ruby/truffle/truffle/objspace.rb

+      count_nodes_tree Truffle::Primitive.ast(method), nodes
+    end
+
+    private :count_nodes_method


For style, usually the private follows the end or then the scope/frame-level private is used only once (better in this case I think).
A third alternative from Ruby 2.2 is private def count_nodes_method(method, nodes) but might be strange for indent reasons.

eregon · 2015-09-14T11:10:36Z

Looks great! And node/allocation stats are always useful.
I think ObjectSpace._id2ref cannot short-circuit anymore, which might slow it down in practice quite a bit.
Why did you remove that? Maybe it could potentially loop since there is no Set involved?
Short-circuit per thread level seems less useful so I don't mind about that.

chrisseaton · 2015-09-14T12:36:12Z

I removed the short circuit as it significantly simplifies the logic of visiting the object graph. I think that trade-off is valid for an operation we don't expect many people to be using. I found a lot of bugs when I actually started to write each_object specs.

Conflicts: truffle/src/main/java/org/jruby/truffle/nodes/core/ObjectSpaceNodes.java truffle/src/main/java/org/jruby/truffle/runtime/core/CoreLibrary.java

eregon · 2015-09-14T13:50:27Z

truffle/src/main/java/org/jruby/truffle/runtime/subsystems/ObjectSpaceManager.java

@@ -55,6 +58,10 @@ public void clearFinalizers() {
    private final ReferenceQueue<DynamicObject> finalizerQueue = new ReferenceQueue<>();
    private DynamicObject finalizerThread;

+    private final CyclicAssumption tracingAssumption = new CyclicAssumption("objspace-tracing");
+    private int tracingAssumptionActivations = 0;
+    private boolean tracingPaused = false;


Thread-safety is a problem here.

Probably ThreadLocal<Boolean> would work, but of course there is some overhead.
And AtomicInteger for tracingAssumptionActivations.

…isn't implemented.

…y are traced.

chrisseaton · 2015-09-15T00:18:15Z

All the MRI tests pass apart from nine.

eregon · 2015-09-15T09:27:49Z

truffle/src/main/java/org/jruby/truffle/runtime/subsystems/SafepointManager.java

+            }
+
+        });
+    }


This seems unused.

eregon · 2015-09-15T09:28:19Z

truffle/src/main/java/org/jruby/truffle/runtime/subsystems/ObjectSpaceManager.java

@@ -55,6 +60,11 @@ public void clearFinalizers() {
    private final ReferenceQueue<DynamicObject> finalizerQueue = new ReferenceQueue<>();
    private DynamicObject finalizerThread;

+    private final CyclicAssumption tracingAssumption = new CyclicAssumption("objspace-tracing");
+    @CompilerDirectives.CompilationFinal private boolean isTracing = false;


This is clearer, thanks!

eregon · 2015-09-15T09:40:00Z

Looks good, Travis overflows on 2 MRI test though.

Conflicts: truffle/src/main/java/org/jruby/truffle/nodes/core/TrufflePrimitiveNodes.java

[Truffle] Implement objspace.

[Truffle] Implement objspace.

63ab92d

chrisseaton added the truffle label Sep 11, 2015

chrisseaton self-assigned this Sep 11, 2015

chrisseaton added this to the truffle-dev milestone Sep 11, 2015

eregon reviewed Sep 13, 2015
View reviewed changes

[Truffle] Typo.

c90af6a

eregon reviewed Sep 14, 2015
View reviewed changes

chrisseaton added 3 commits September 14, 2015 13:36

[Truffle] Formatting.

77063ef

[Truffle] Fix return of _id2ref

1f0f67d

Merge branch 'master' into truffle-objspace

88c716e

Conflicts: truffle/src/main/java/org/jruby/truffle/nodes/core/ObjectSpaceNodes.java truffle/src/main/java/org/jruby/truffle/runtime/core/CoreLibrary.java

eregon reviewed Sep 14, 2015
View reviewed changes

chrisseaton added 9 commits September 14, 2015 18:19

[Truffle] Adapt count_tdata_objects to do something useful.

8c3aa43

[Truffle] Special cases for sizeof nil and MatchData.

9991034

[Truffle] Track allocation generations when tracing.

85e38aa

[Truffle] Fix allocation tracing states.

de630e0

[Truffle] Fix the stored fields when allocation tracing.

22fe01d

[Truffle] Shim ARGFClass.inplace_mode until we can figure out why it …

f1d583f

…isn't implemented.

[Truffle] Classes don't always have names!

407033b

[Truffle] Use AllocateObjectNode for string and array literals so the…

f6b4753

…y are traced.

[Truffle] Enable MRI objspace specs.

7878a2e

eregon reviewed Sep 15, 2015
View reviewed changes

truffle/src/main/java/org/jruby/truffle/runtime/subsystems/SafepointManager.java

}

});

}

Copy link

Member

eregon Sep 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unused.

eregon reviewed Sep 15, 2015
View reviewed changes

chrisseaton added 3 commits September 15, 2015 14:30

[Truffle] Transform recursion to looping for arbitrarily deep ASTs.

8d06e9c

Merge branch 'master' into truffle-objspace

4dcc1ed

Conflicts: truffle/src/main/java/org/jruby/truffle/nodes/core/TrufflePrimitiveNodes.java

[Truffle] Removed unused pauseAllThreadsAndExecuteOnOneThread

5596ea0

chrisseaton added a commit that referenced this pull request Sep 15, 2015

Merge pull request #3321 from jruby/truffle-objspace

4447250

[Truffle] Implement objspace.

chrisseaton merged commit 4447250 into master Sep 15, 2015

chrisseaton deleted the truffle-objspace branch September 15, 2015 18:11

enebo added this to the Non-Release milestone Dec 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

[Truffle] Implement objspace. #3321

[Truffle] Implement objspace. #3321

chrisseaton commented Sep 11, 2015

eregon Sep 13, 2015

chrisseaton Sep 13, 2015

eregon Sep 14, 2015

eregon commented Sep 14, 2015

chrisseaton commented Sep 14, 2015

eregon Sep 14, 2015

eregon Sep 14, 2015

chrisseaton commented Sep 15, 2015

eregon Sep 15, 2015

eregon Sep 15, 2015

eregon commented Sep 15, 2015

+                          }
+                      });
+                  }

[Truffle] Implement objspace. #3321

[Truffle] Implement objspace. #3321

Conversation

chrisseaton commented Sep 11, 2015

eregon Sep 13, 2015

Choose a reason for hiding this comment

chrisseaton Sep 13, 2015

Choose a reason for hiding this comment

eregon Sep 14, 2015

Choose a reason for hiding this comment

eregon commented Sep 14, 2015

chrisseaton commented Sep 14, 2015

eregon Sep 14, 2015

Choose a reason for hiding this comment

eregon Sep 14, 2015

Choose a reason for hiding this comment

chrisseaton commented Sep 15, 2015

eregon Sep 15, 2015

Choose a reason for hiding this comment

eregon Sep 15, 2015

Choose a reason for hiding this comment

eregon commented Sep 15, 2015