Avoiding Nikola trying to cache posts which aren't written anyway. #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,6 +77,8 @@ def tl_ch(): | |||
| deps_dict = copy(kw) | |||
| deps_dict.pop('timeline') | |||
| for post in kw['timeline']: | |||
| if not post.is_translation_available(lang) and not self.site.config['SHOW_UNTRANSLATED_POSTS']: | |||
| return | |||
There was a problem hiding this comment.
That won’t do, it will kill the task generator for all posts. Try continue.
There was a problem hiding this comment.
Yikes, that's what I wanted to do. Thanks for catching this!
Kwpolska
added a commit
that referenced
this pull request
Sep 6, 2015
Avoiding Nikola trying to cache posts which aren't written anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
SHOW_UNTRANSLATED_POSTSis set toFalseand a post's translation doesn't exist, Nikola nonetheless tries to create the cached post every timenikola buildis run. Since it never creates it anyway (as it notices that the translation isn't available andSHOW_UNTRANSLATED_POSTSis set toFalse-- there's identical code to the one I inserted inPost.compilewhich simply returns in this condition), there's no need to schedule a task for it.