implemented real webac delegate + unit tests #29
Conversation
| final Map<String, String> map = new HashMap<>(); | ||
| // WEBAC_MODE_READ Permissions | ||
| map.put(READ, WEBAC_MODE_READ_VALUE); | ||
| // WEBAC_MODE_WRITE Permissions |
There was a problem hiding this comment.
We probably should include "DELETE" and "UPDATE" as subclasses of "WRITE", as discussed in meetings.
There was a problem hiding this comment.
I don't believe there exist DELETE or UPDATE actions (but c.f. REMOVE and SET_PROPERTY). The full list of MODE permissions are here: http://git.io/vZUuD (github) and http://docs.jboss.org/modeshape/4.2.0.Final/api/org/modeshape/jcr/ModeShapePermissions.html (javadocs)
There was a problem hiding this comment.
I am referring to the non-standard F4-WebAC modes of DELETE and UPDATE, not ModeShape actions.
See: https://wiki.duraspace.org/display/FF/Design+-+WebAccessControl+Authorization+Delegate#Design-WebAccessControlAuthorizationDelegate-ProposedRequirements(Phase1)
|
@awoods fixed typo and clarified code comment. |
|
Resolved with: 7e5b14d |
This implements a mostly-working WebAC delegate, based on the values produced by the WebACRolesProducer in #28
Some outstanding issues include:
acl:accessControldeclaration (and corresponding Acl/Authorizations that apply to the principal) do not permit access, but child resources do.This has been tested manually with webapp-plus.