[find-bugs] remove (unused) helpers - currently always end-up with Ty…

…peError otherwise they would NPE due `RubyModule module = null; // ...`
jruby · Sep 9, 2015 · ed3d429 · ed3d429
1 parent 4b48b23
commit ed3d429
Showing 1 changed file with 1 addition and 31 deletions.
diff --git a/core/src/main/java/org/jruby/runtime/Helpers.java b/core/src/main/java/org/jruby/runtime/Helpers.java
@@ -1394,42 +1394,12 @@ public static RubyHash constructSmallHash(Ruby runtime,
         return hash;
     }
 
-    public static IRubyObject undefMethod(ThreadContext context, Object nameArg) {
-        RubyModule module = null; // context.getRubyClass();
-        String name = (nameArg instanceof String) ?
-            (String) nameArg : nameArg.toString();
-
-        if (module == null) {
-            throw context.runtime.newTypeError("No class to undef method '" + name + "'.");
-        }
-
-        module.undef(context, name);
-
-        return context.runtime.getNil();
-    }
-
-    public static IRubyObject defineAlias(ThreadContext context, IRubyObject self, Object newNameArg, Object oldNameArg) {
-        Ruby runtime = context.runtime;
-        RubyModule module = null; // context.getRubyClass();
-
-        if (module == null || self instanceof RubyFixnum || self instanceof RubySymbol){
-            throw runtime.newTypeError("no class to make alias");
-        }
-
-        String newName = newNameArg.toString();
-        String oldName = oldNameArg.toString();
-
-        module.defineAlias(newName, oldName);
-        module.callMethod(context, "method_added", runtime.newSymbol(newName));
-
-        return runtime.getNil();
-    }
-
     public static IRubyObject negate(IRubyObject value, Ruby runtime) {
         if (value.isTrue()) return runtime.getFalse();
         return runtime.getTrue();
     }
 
+    @Deprecated // no-longer used + confusing argument order
     public static IRubyObject stringOrNil(ByteList value, ThreadContext context) {
         if (value == null) return context.nil;
         return RubyString.newStringShared(context.runtime, value);