Making path handlers of indexes plugin work before get_tasks() is run. #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| site.register_path_handler('index', self.index_path) | ||
| site.register_path_handler('index_atom', self.index_atom_path) | ||
| site.register_path_handler('section_index', self.index_section_path) | ||
| site.register_path_handler('section_index_atom', self.index_section_atom_path) | ||
| return super(Indexes, self).set_site(site) | ||
|
|
||
| def _get_filtered_posts(self, lang, show_untranslated_posts): |
There was a problem hiding this comment.
this function name should be more informative. Also, using _underscores is not a valid reason to skip documenting things.
There was a problem hiding this comment.
Ah, that pep257 tool doesn't complain about missing docstrings for underscore names apparently. Good to know.
There was a problem hiding this comment.
It believes they are private, which often makes sense, but it’s good to throw in a docstring nevertheless.
|
The failed check is due to some invariance breaking, which seems to not be the fault of this PR. |
|
@Aeyoun, mind reviewing and merging? |
|
Anyone minds if I merge? |
Kwpolska
added a commit
that referenced
this pull request
Sep 13, 2015
Making path handlers of indexes plugin work before get_tasks() is run.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2040.