Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] allow Kernel#system and Process.spawn to be called with arr… #3315

Merged
merged 3 commits into from
Sep 15, 2015

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Sep 9, 2015

…ay of arguments

only :unsetenv_others is supported for now

@pitr-ch pitr-ch added the truffle label Sep 9, 2015
@pitr-ch pitr-ch self-assigned this Sep 9, 2015
@pitr-ch pitr-ch added this to the truffle-dev milestone Sep 9, 2015
@ShortCircuit("value")
protected boolean needsValue() {
return false;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a strange usage of @ShortCircuit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it is, but i do not know about another way how to disable value being executed twice.

@eregon
Copy link
Member

eregon commented Sep 14, 2015

Looks good!

@pitr-ch pitr-ch merged commit 181d3c9 into jruby:master Sep 15, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants