Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up/reorg maven config, inheriting from fcrepo-parent #53

Closed
wants to merge 2 commits into from
Closed

clean up/reorg maven config, inheriting from fcrepo-parent #53

wants to merge 2 commits into from

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented Sep 14, 2015

</configuration>
</plugin>
<plugin>
<artifactId>maven-changelog-plugin</artifactId>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to keep this plugin, minus the <configuration> block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-added the changelog plugin

</plugin>
</plugins>
</reporting>


<profiles>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running: mvn help:effective-pom, it appears that fcrepo-camel-webapp/pom.xml "profiles" overwrites the inheritance of these release-related profiles, which likely argues for not removing them from here until we drop fcrepo-camel-webapp.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other note -- the profiles are not being overwritten. Inherited profiles are not displayed in mvn help:effective-pom, but they are when you run mvn help:all-profiles. With that second command you will see that both release-sign-artifacts and sonatype-oss-release are present for all modules but inactive.

@awoods
Copy link

awoods commented Sep 30, 2015

Resolved with: a774c5d

@awoods awoods closed this Sep 30, 2015
@acoburn acoburn deleted the fcrepo-1728 branch September 30, 2015 20:33
@acoburn acoburn restored the fcrepo-1728 branch October 2, 2015 13:05
@acoburn acoburn deleted the fcrepo-1728 branch October 4, 2015 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants