Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/cleanup maven to use fcrepo-parent #93

Merged
merged 1 commit into from Sep 30, 2015
Merged

update/cleanup maven to use fcrepo-parent #93

merged 1 commit into from Sep 30, 2015

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented Sep 14, 2015

</plugin>
</plugins>
</build>

<profiles>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running: mvn help:effective-pom, it appears that the parent release-related "profiles" (or any) are not being inherited from fcrepo-parent/pom.xml.
If that can not be resolved, we should probably keep this "profiles" section intact.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a different understanding of how profiles work. Basically, mvn help:effective-pom displays only the effective profile. If you want to see the "release-sign-artifacts" profile, try this: mvn help:effective-pom -Prelease-sign-artifacts. The output of that includes the maven-gpg-plugin, which otherwise is not present.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... in order to see all profiles, use mvn help:all-profiles. you will see that the release-related profiles are not overwritten.

awoods pushed a commit that referenced this pull request Sep 30, 2015
update/cleanup maven to use fcrepo-parent
@awoods awoods merged commit 2ef9b07 into fcrepo-exts:master Sep 30, 2015
@acoburn acoburn deleted the fcrepo-1728 branch September 30, 2015 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants