Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find-bugs 2 #3319

Merged
merged 26 commits into from
Sep 11, 2015
Merged

find-bugs 2 #3319

merged 26 commits into from
Sep 11, 2015
+171 −194

Conversation

kares
Copy link
Member

@kares kares commented Sep 10, 2015

second service, please review ... if smt does not feel right - comment

kares added 26 commits September 10, 2015 08:07
@kares
[find-bugs] inefficient string buffering - avoid concatenating and em…
1493eb7 
…pty string
@kares
[find-bugs] inefficient string buffering - avoid passing concatenatin…
fc96fcd 
…g string to builder
@kares
[find-bugs] avoid using a ternary operator to cast a boolean to true/…
586c18e 
…false
@kares
[find-bugs] avoid empty string concatenation in IR
6ea1639
@kares
[find-bugs] avoid additional string concatenation while using a Strin…
4863e1d 
…gBuilder
@kares
[find-bugs] avoid string concatenation while using a StringBuilder + …
92956b9 
…guess size
@kares
[find-bugs] avoid string concatenation (in a loop) while using a Stri…
c2abe75 
…ngBuilder
@kares
[find-bugs] avoid unecessary string builder use - compiler can concat…
8b453d3 
…enate statics
@kares
[find-bugs] remove un-used private methods
39756de
@kares
[find-bugs] avoid calling same method twice - keep module.getClass(Ty…
f767fdc 
…pe) locally
@kares
[find-bugs] use local map instead of calling the same method again in…
993655d 
… ScriptingContainer
@kares
[find-bugs] avoid unnecessary calling getRuntime() and getCurrentCont…
43f13df 
…ext() twice
@kares
[find-bugs] avoid calling selectChannel() twice + avoid getRuntime() …
781a8f4 
…several times
@kares
re-use tracking Set instance in the loop instead of creating a new on…
e79372d 
…e each time
@kares
[find-bugs] avoid calling same method twice - avoid double toString()
b44f77f
@kares
[find-bugs] avoid using strings of length == 1 in favor of chars
b528582
@kares
[find-bugs] do not execute same method twice - avoid consecutive runt…
acf32cd 
…ime.getClass
@kares
[find-bugs] avoid potentially creating the same File instance twice
f38f397
@kares
[find-bugs] only execute runtime.getClassFromPath once + use iterable…
3c8e449 
… for-loop
@kares
[find-bugs] avoid creating consecutive newSymbol + remove unused priv…
f2b3f48 
…ate method
@kares
[find-bugs] favor local var instead of executing same code twice/over…
e5f37ba 
… + clean if-else
@kares
[find-bugs] add some local vars for re-use + builder instead of strin…
a093817 
…g concat (due loop)
@kares
[find-bugs] do no ask for getMethodsForWrite() twice esp. since its s…
d88ea19 
…ynchronized
@kares
[find-bugs] keep getPath in a local variable instead of calling it twice
2edf70d
@kares
no need to initialize a local to null
bc1962f
@kares
[find-bugs] avoid empty string contatenation + favor chars instead of…
e82eaeb 
… 1 size strings
enebo added a commit that referenced this pull request Sep 11, 2015
@enebo
Merge pull request #3319 from jruby/test-findbugs-2
976c968 
find-bugs 2
@enebo enebo merged commit 976c968 into master Sep 11, 2015
@enebo enebo added this to the JRuby 9.0.2.0 milestone Sep 11, 2015
@kares kares deleted the test-findbugs-2 branch September 14, 2015 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kares @enebo