Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1493eb7c370c^
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e82eaeb5a442
Choose a head ref
1 contributor

Commits on Sep 10, 2015

  1. [find-bugs] inefficient string buffering - avoid concatenating and em… 

    …pty string
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    1493eb7 View commit details

  2. [find-bugs] inefficient string buffering - avoid passing concatenatin… 

    …g string to builder
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    fc96fcd View commit details

  3. [find-bugs] avoid using a ternary operator to cast a boolean to true/… 

    …false
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    586c18e View commit details

  4. [find-bugs] avoid empty string concatenation in IR

    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    6ea1639 View commit details

  5. [find-bugs] avoid additional string concatenation while using a Strin… 

    …gBuilder
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    4863e1d View commit details

  6. [find-bugs] avoid string concatenation while using a StringBuilder + … 

    …guess size
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    92956b9 View commit details

  7. [find-bugs] avoid string concatenation (in a loop) while using a Stri… 

    …ngBuilder
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    c2abe75 View commit details

  8. [find-bugs] avoid unecessary string builder use - compiler can concat… 

    …enate statics
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    8b453d3 View commit details

  9. [find-bugs] remove un-used private methods

    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    39756de View commit details

  10. [find-bugs] avoid calling same method twice - keep module.getClass(Ty… 

    …pe) locally
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    f767fdc View commit details

  11. [find-bugs] use local map instead of calling the same method again in… 

    … ScriptingContainer
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    993655d View commit details

  12. [find-bugs] avoid unnecessary calling getRuntime() and getCurrentCont… 

    …ext() twice
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    43f13df View commit details

  13. [find-bugs] avoid calling selectChannel() twice + avoid getRuntime() … 

    …several times
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    781a8f4 View commit details

  14. re-use tracking Set instance in the loop instead of creating a new on… 

    …e each time
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    e79372d View commit details

  15. [find-bugs] avoid calling same method twice - avoid double toString()

    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    b44f77f View commit details

  16. [find-bugs] avoid using strings of length == 1 in favor of chars

    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    b528582 View commit details

  17. [find-bugs] do not execute same method twice - avoid consecutive runt… 

    …ime.getClass
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    acf32cd View commit details

  18. [find-bugs] avoid potentially creating the same File instance twice

    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    f38f397 View commit details

  19. [find-bugs] only execute runtime.getClassFromPath once + use iterable… 

    … for-loop
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    3c8e449 View commit details

  20. [find-bugs] avoid creating consecutive newSymbol + remove unused priv… 

    …ate method
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    f2b3f48 View commit details

  21. [find-bugs] favor local var instead of executing same code twice/over… 

    … + clean if-else
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    e5f37ba View commit details

  22. [find-bugs] add some local vars for re-use + builder instead of strin… 

    …g concat (due loop)
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    a093817 View commit details

  23. [find-bugs] do no ask for getMethodsForWrite() twice esp. since its s… 

    …ynchronized
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    d88ea19 View commit details

  24. [find-bugs] keep getPath in a local variable instead of calling it twice

    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    2edf70d View commit details

  25. no need to initialize a local to null

    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    bc1962f View commit details

  26. [find-bugs] avoid empty string contatenation + favor chars instead of… 

    … 1 size strings
    @kares
    kares committed Sep 10, 2015
    Copy the full SHA
    e82eaeb View commit details
Loading