Issue #3324 #3327
Issue #3324 #3327
Conversation
|
najs, would you mind cleaning-up the commits ? |
| @@ -114,7 +114,7 @@ public static IRubyObject id2ref(IRubyObject recv, IRubyObject id) { | |||
| return object; | |||
| } else { | |||
| runtime.getWarnings().warn("ObjectSpace is disabled; _id2ref only supports immediates, pass -X+O to enable"); | |||
| return runtime.getNil(); | |||
| throw recv.getRuntime().newRangeError(id+" This is not id value"); | |||
There was a problem hiding this comment.
Can you try to replicate the error message exactly? It should be 0x00000000000000 is not id value, which you can probably make with String.format('%016x is not id value', id).
There was a problem hiding this comment.
@chrisseaton I will do it.
|
@bitfurry Thanks for the patch! In the future, please include the issue title or some other context in the commit message. We have a fair number of people that use the JRuby repository without constant access to GitHub. While "issue #3324" links great on GitHub site, it's far less usable from the command-line or non-GitHub mirrors. |
|
The failure looks unrelated, and I'll merge now rather than pestering you about the unrelated line again. Thanks very much for your contribution! |
_id2ref should raise RangeError rather than return nil for no object found
The issue was that _id2ref function was retruing nil value. I fixed it to throw a RangeError. Please correct me if I am wrong at any point.