Fix sf#396, Module docs can not be found more than once. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user did 'help PDL::IO::Storable' or some other 2-deep module name, the search for the proper module file from which to display docs would change the reported location of the docs database (and the documentation head) in a initialized once-per-pdl-shell variable. Subsequent searches would be looking for PDL/IO/IO/Storable.pm, PDL/IO/IO/IO/Storable.pm, etc, which couldn't be found. This was due to how foreach aliases the loop variable to the input array. Making an explicit copy removes the aliasing and keeps the variable unchanged.
d-lamb
added a commit
that referenced
this pull request
Sep 17, 2015
Fix sf#396, Module docs can not be found more than once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user did 'help PDL::IO::Storable' or some other 2-deep module name,
the search for the proper module file from which to display docs
would change the reported location of the docs database (and the documentation head)
in a initialized once-per-pdl-shell variable. Subsequent searches would
be looking for PDL/IO/IO/Storable.pm, PDL/IO/IO/IO/Storable.pm, etc,
which couldn't be found. This was due to how foreach aliases the
loop variable to the input array. Making an explicit copy removes
the aliasing and keeps the variable unchanged.