allow patch to optionally create intermediate dirs #1506
Conversation
| @@ -453,7 +453,9 @@ This removes the link named foo from the hash in $FOO_BAR and returns the | |||
| resulting object hash. | |||
| `, | |||
| }, | |||
| Options: []cmds.Option{}, | |||
| Options: []cmds.Option{ | |||
| cmds.BoolOption("create", "p", "create intermediate directories on add-link"), | |||
|
dont merge quite yet, i might want to tweak something |
whyrusleeping
force-pushed
the
feat/patch-create
branch
2 times, most recently
from
95041f5 to
f1d8b2f
Compare
|
lmk when ready |
|
@jbenet RFM |
whyrusleeping
force-pushed
the
feat/patch-create
branch
from
f1d8b2f to
c95c097
Compare
| return nil, err | ||
| } | ||
|
|
||
| _, err = ds.Add(root) |
There was a problem hiding this comment.
this is just making sure the object is in ds? not sure why it's needed, in which case won't it be?
There was a problem hiding this comment.
Oh, i see. if it's been modified!
There was a problem hiding this comment.
these mutable nodes really bother me. i'd be so much more comfortable with:
node := dag.RemoveLink(root, path[0])
|
@whyrusleeping comments above |
|
@jbenet RFM |
| } | ||
|
|
||
| ctx, cancel := context.WithTimeout(ctx, time.Second*30) | ||
| defer cancel() |
There was a problem hiding this comment.
no timeout here. caller's responsibility.
if you're worried about the "running out of time" problem (e.g. user gives context with timeout T, to do K steps, but we can estimate that if step 1 takes > T/K time, we should fail early and avoid wasting resources on a doomed-to-run-out-of-time operation) use https://godoc.org/github.com/jbenet/go-context/frac
There was a problem hiding this comment.
mmm, my bad, thats a holdover from being in the commands lib with no explicit timeout.
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/patch-create
branch
from
ea5b8b3 to
b32d0ef
Compare
| return ErrNotFound | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
@whyrusleeping pls add test for this o/ else it may get broken again
|
@whyrusleeping LGTM -- one minor thing: test the Remove Link func in node. other than that, RFM |
|
@jbenet theres those tests, I'll have more merkledag test coverage on 0.4.0 as i use and test FetchGraph |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/patch-create
branch
from
5bd99f5 to
aa7d946
Compare
allow patch to optionally create intermediate dirs
|
thanks @whyrusleeping ❤️ 👏 ❤️ 👏 ❤️ 👏 ❤️ 👏 ❤️ 👏 |
Docker stuff is a headache without this option. We can also make it a different sub-command if that makes more sense.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com