Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java integration specs for RSpec 3+ #3159

Closed
headius opened this issue Jul 21, 2015 · 10 comments
Closed

Update Java integration specs for RSpec 3+ #3159

headius opened this issue Jul 21, 2015 · 10 comments

Comments

@headius
Copy link
Member

headius commented Jul 21, 2015

Our Java integration specs (spec/java_integration) are currently not RSpec 3+ compatible. At a minimum, they used methods deprecated in late 2.x, and they also use syntax that's deprecated with noisy warnings in 3+. They should be updated to RSpec 3.x syntax and our build updated to pull in RSpec 3.x when bootstrapping local dev environment.

This change should be made on both jruby-1_7 and master branches.

@headius
Copy link
Member Author

headius commented Jul 21, 2015

Run the specs with rake spec:ji.

These specs can be run directly, but there's some classpath stuff that will fail.

@PragTob
Copy link

PragTob commented Jul 21, 2015

(interested in trying to tackle this)

should/might be doable with transpec and I've done this sort of thing before. No idea how big the spec files are but seems like a fun little project, I got vacation the week before JRubyConf.EU so this time I might REALLY get to my first JRuby commit.

@headius
Copy link
Member Author

headius commented Jul 21, 2015

Go for it! Right now the specs don't run at all with RSpec 3+, so it's pretty annoying when I have that installed.

@myronmarston
Copy link

@PragTob sounds like you're already aware of this (given you mentioned transpec) but in case you're not: our upgrade guide. Please reach out if you run into any difficulties.

@PragTob
Copy link

PragTob commented Jul 22, 2015

@myronmarston did not know the upgrade guide - thanks :) More or less what I'd have done - transpec and co worked beautifully for us over at [shoes4[(https://github.com/shoes/shoes4) :)

@kares
Copy link
Member

kares commented Jul 22, 2015

been avoiding some of the noizy warnings on jruby-1_7 branch ... was also hoping to review the JI pends

@PragTob in case you're doing it do jruby-1_7 branch instead of master - for less potential conflicts :)

@PragTob
Copy link

PragTob commented Jul 22, 2015

@kares shouldn't it end up on both branches? I don't know how you actually work with that? I thought of starting at one branch and then cherry picking the commit? Sorry never maintained a project with 2 major branches :)

@kares
Copy link
Member

kares commented Jul 22, 2015

@PragTob jruby-1_7 is merged periodically to master so it will end up there as well (just a hint - if its easier for you to roll of master we can cherry-pick them from there ... although it might be a bit more work)

@envygeeks
Copy link

You would have to travel into the master branch anyways because there are added spec files so it doesn't matter if you cherry pick those changes, I would simply just merge and let it fail, edit the failed files (it looks to me like < 10 would fail -- probably not that much work) and then edit the added files and change them. All in all this project could probably be completed in a few days.

@kares
Copy link
Member

kares commented Sep 14, 2015

done at #3265

@kares kares closed this as completed Sep 14, 2015
@enebo enebo added this to the Non-Release milestone Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants