Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print output on test failure for t0081 #1510

Merged
merged 1 commit into from
Jul 28, 2015
Merged

print output on test failure for t0081 #1510

merged 1 commit into from
Jul 28, 2015

Conversation

whyrusleeping
Copy link
Member

seeing another random failure that I may be responsible for here: #1508

This should help figure out whats going on.

Also removed a debug statement i accidentally left in.

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

@jbenet jbenet added the status/in-progress In progress label Jul 23, 2015
@whyrusleeping
Copy link
Member Author

mmm, those test failures really make me want #1501 in even more

@jbenet
Copy link
Member

jbenet commented Jul 23, 2015

I think this is unrelated to #1501

@whyrusleeping
Copy link
Member Author

@jbenet the travis test failures are exactly what i fixed in #1501, what do you mean they are unrelated?

@@ -60,11 +60,6 @@ on disk.
recursive = false
}

go func() {
<-req.Context().Done()
log.Error("CONTEXT IS OVER!")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wat.

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
jbenet added a commit that referenced this pull request Jul 28, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
print output on test failure for t0081
@jbenet jbenet merged commit f417cb5 into master Jul 28, 2015
@jbenet jbenet deleted the pinfail-debug branch July 28, 2015 01:41
@jbenet jbenet removed the status/in-progress In progress label Jul 28, 2015
@jbenet jbenet modified the milestone: IPFS 0.3.6 Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants