-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] splat position; Thread#backtrace #3191
Conversation
I would call *arg in an argument list a |
I think what you suggest is not enough because of post-splat arguments. The position can be smaller than required+optional. It could be |
How so? The frame will contain the arguments in order, so for instance at the position of an optional argument there will be either the given value or the default one. |
6e134f9
to
280a602
Compare
//TODO (MS): Check merge | ||
|
||
//TODO (MS): Check merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these unintentional changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, what's our policy on these changes, separate commits or don't? I feel these trailing spaces as malformed code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry I misread the diff, I thought the diff added the extra spaces.
Removing neighboring style issues is fine.
d788fdc
to
97f7e3b
Compare
Looks good, bonus point if you can rebase on master :) |
f196e52
to
11aae78
Compare
so rspec can correctly report errors
No description provided.