-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize path (windows) #3167
normalize path (windows) #3167
Conversation
@ahorek seems good but without a test is a little less worthy, any chance you do a test-case or tell us what use-case (sample .rb script) has been failing for you that the change fixes? thanks |
@kares - hi, most jruby tests don't work on windows and this is windows specific. Failing scenario is already described in the related issue.
=> for windows it should look something like this:
|
seems good ... @mkristian what do you think of: |
the usual java vs. ruby paths. yes, this is OK. still a test which passes on windows as on unix would be great. one there we will have a CI running on windows and then it is important that we have a good test coverage for those windows only cases. test/jruby/test_file.rb is also a good place for such a test as this is in jruby direct control. |
@mkristian thanks I wasn't sure since its been a while when a tried JRuby on Windows. |
02bd228
to
6b947e0
Compare
6b947e0
to
c39825f
Compare
@kares - I've added very simple cases, is it ok? this fix should be also backported to JRuby 1.7.23 |
@ahorek looks good, we're in the process of merging jruby-1_7 into master, |
fixes #3132