Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a C-API "rb_hash_clear" #3477

Merged
merged 1 commit into from Jul 30, 2015
Merged

Add a C-API "rb_hash_clear" #3477

merged 1 commit into from Jul 30, 2015

Conversation

kachick
Copy link
Member

@kachick kachick commented Jul 29, 2015

No description provided.

@kachick kachick added the C-API Compatibility Function and feature compatibility with the MRI C-API label Jul 29, 2015
yorickpeterse
yorickpeterse reviewed Jul 29, 2015
View reviewed changes
spec/ruby/optional/capi/hash_spec.rb
@@ -91,6 +91,14 @@
end
end

describe "rb_hash_clear" do
it "returns self that cleared keys and values" do
hsh = { key: 'value' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the hash rocket syntax here? We'll probably want to backport this to our 1.8 branch which IIRC doesn't support the new symbol syntax.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yorickpeterse Sure. I'll update with hash rocket :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yorickpeterse yorickpeterse merged commit f68f9a0 into rubinius:master Jul 30, 2015
@yorickpeterse
Copy link
Contributor

Thanks!

@kachick
Copy link
Member Author

kachick commented Jul 30, 2015

Thanks to merge!

@kachick kachick deleted the capi-rb_hash_clear branch July 30, 2015 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-API Compatibility Function and feature compatibility with the MRI C-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kachick @yorickpeterse