Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log tail command #1539

Merged
merged 3 commits into from
Jul 29, 2015
Merged

fix log tail command #1539

merged 3 commits into from
Jul 29, 2015

Conversation

whyrusleeping
Copy link
Member

ipfs log tail works again, turns out its much easier with the new code.

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

@jbenet jbenet added the status/in-progress In progress label Jul 29, 2015
@whyrusleeping whyrusleeping added this to the IPFS 0.3.6 milestone Jul 29, 2015
@whyrusleeping
Copy link
Member Author

hrm... apparently the context doesnt behave like i expected it to. I had thought killing the client side would cancel the context. Gotta rewrite something

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@jbenet
Copy link
Member

jbenet commented Jul 29, 2015

so with this PR it's exposed in both http routes, correct? (this looks fine to me)

@whyrusleeping
Copy link
Member Author

@jbenet yeap! its exposed in both places. I could remove the one at /logs if you like.

@jbenet
Copy link
Member

jbenet commented Jul 29, 2015

@whyrusleeping fine keeping it in both places by me.

jbenet added a commit that referenced this pull request Jul 29, 2015
@jbenet jbenet merged commit 8a75c75 into master Jul 29, 2015
@jbenet jbenet removed the status/in-progress In progress label Jul 29, 2015
@jbenet jbenet deleted the log-api-route branch July 29, 2015 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants