Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try method added to object #5

Merged
merged 1 commit into from
Jul 28, 2015
Merged

try method added to object #5

merged 1 commit into from
Jul 28, 2015

Conversation

patleb
Copy link

@patleb patleb commented Jul 28, 2015

No description provided.

elia added a commit that referenced this pull request Jul 28, 2015

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
try method added to object
@elia elia merged commit 94daf09 into opal:master Jul 28, 2015
@elia
Copy link
Member

elia commented Jul 28, 2015

Thanks!

You think you can add some specs for the added methods in another PR?

@patleb
Copy link
Author

patleb commented Jul 28, 2015

Your welcome!
I'm a bit in a rush until September at the job. I can't guarantee I will add some specs soon but, yes, I will add some specs eventually. In the meantime, "try" and "constantize" are already in use in my application (which one part is kind of a rewrite of Paloma with Opal) and everything is working fine.

@elia
Copy link
Member

elia commented Jul 28, 2015

np for the specs, also they're usually quite easy as you can reuse most of the stuff from the original AS tests

Didn't know about Paloma, cool stuff, on my side I'd putting together something similar but specifically targeted at Turbolinks.

ajjahn added a commit to ajjahn/opal-activesupport that referenced this pull request Oct 8, 2015
ajjahn added a commit to ajjahn/opal-activesupport that referenced this pull request Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants