-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise Based Async Support – reprise (thanks to @wied03!) #25
Conversation
awesome, thanks everyone! |
* Run_examples hack on example group seems to work now
…summary results reflect failures properly * Clean up puts statements
…irst one for the results, and test for it using the old "should make example fail before async block reached" test
…example should be considered complete * Use that to make skip within an example work
Get descendant example groups working with promises (and share code)
* Put tests into contexts to make spec less verbose
…match that) * Run_after_example had code that ran after the hooks, so needed to wrap that in promises
… specs with async before(:each) +after(:each) now work
…ks, and after better promise understanding, do a more literal conversion of begins/rescues/ensures to promises
* Got something that works as long as the around block does not fail, need to figure out how to fix that
…tly rather than evaluating it in the group in commit b0a4659, all of these specs can be streamlined
…t submodules + Opal append path
@wied03 I rebased against master and it's ready to merge 🎉 Before that I have a question: is it necessary to remove the old async stuff that @adambeynon did? |
@elia and @adambeynon - Maybe. One way would be to just make 'async' an alias for 'it', then 'run_async' becomes an alias for delay_with_promise(0) |
Still need to wrap my head around the new async stuff but sounds good, I'll merge. Can you send after I merge a PR that adds back those methods along with a note in the README and CHANGELOG? Btw the tests (as in |
Promise Based Async Support – reprise (thanks to @wied03!)
Yep |
fixes #21
cc @wied03 @ryanstout @adambeynon