Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise Based Async Support – reprise (thanks to @wied03!) #25

Merged
merged 118 commits into from
Jul 28, 2015

Conversation

elia
Copy link
Member

@elia elia commented Jul 27, 2015

@ryanstout
Copy link

awesome, thanks everyone!

wied03 added 29 commits July 28, 2015 20:21
* Run_examples hack on example group seems to work now
…summary results reflect failures properly

* Clean up puts statements
…irst one for the results, and test for it using the old "should make example fail before async block reached" test
…example should be considered complete

* Use that to make skip within an example work
Get descendant example groups working with promises (and share code)
* Put tests into contexts to make spec less verbose
wied03 and others added 22 commits July 28, 2015 20:45
…match that)

* Run_after_example had code that ran after the hooks, so needed to wrap that in promises
… specs with async before(:each) +after(:each) now work
…ks, and after better promise understanding, do a more literal conversion of begins/rescues/ensures to promises
* Got something that works as long as the around block does not fail, need to figure out how to fix that
…tly rather than evaluating it in the group in commit b0a4659, all of these specs can be streamlined
@elia
Copy link
Member Author

elia commented Jul 28, 2015

@wied03 I rebased against master and it's ready to merge 🎉

Before that I have a question: is it necessary to remove the old async stuff that @adambeynon did?
If not I'd rather prefer to keep it as some apps could depend on it (and I also kinda liked the async name 😉).

cc @adambeynon @ryanstout

@wied03
Copy link
Contributor

wied03 commented Jul 28, 2015

@elia and @adambeynon - Maybe. One way would be to just make 'async' an alias for 'it', then 'run_async' becomes an alias for delay_with_promise(0)

@elia
Copy link
Member Author

elia commented Jul 28, 2015

Still need to wrap my head around the new async stuff but sounds good, I'll merge. Can you send after I merge a PR that adds back those methods along with a note in the README and CHANGELOG?

Btw the tests (as in rake test) are much better now, thanks!

elia added a commit that referenced this pull request Jul 28, 2015
Promise Based Async Support – reprise (thanks to @wied03!)
@elia elia merged commit d6464d4 into master Jul 28, 2015
@elia elia deleted the async-subject branch July 28, 2015 23:52
@wied03
Copy link
Contributor

wied03 commented Jul 29, 2015

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants