set identity on core mock to fix ipns tests #1524
Merged
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
fix/coremock
branch
from
0adad66 to
c64f743
Compare
|
@jbenet could you run the ipns tests on your laptop? |
|
@whyrusleeping we should setup FUSE on CI, i believe people found a way to get it on travis ci -- travis-ci/travis-ci#1100 ? |
| @@ -54,6 +54,7 @@ func NewMockNode() (*core.IpfsNode, error) { | |||
| nd.Peerstore = peer.NewPeerstore() | |||
| nd.Peerstore.AddPrivKey(p, ident.PrivateKey()) | |||
| nd.Peerstore.AddPubKey(p, ident.PublicKey()) | |||
| nd.Identity = p | |||
There was a problem hiding this comment.
@rht you're right, that's a bug. core.Offline(...) should initialize from the config.Identity -- though maybe the problem is a lack of a private key? not sure.
There was a problem hiding this comment.
well, no. we should be using the nodebuilder here. core.Offline doesnt load identity because it doesnt load the private key, thats an expensive operation that we dont want to happen every time you run a command offline
There was a problem hiding this comment.
So this means any tests using coremock.NewMockNode() loads private key, while the tests that use core.NewIPFSNode (e.g. https://github.com/ipfs/go-ipfs/blob/master/core/coreunix/add_test.go#L28) don't.
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Juan Batiz-Benet <juan@benet.ai>
|
|
jbenet
added a commit
that referenced
this pull request
Jul 29, 2015
set identity on core mock to fix ipns tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuse tests were failing because the mock node didnt have the identity set.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com