[Truffle] Add to loadedFeatures before loading #3192
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelleville
changed the title
bbelleville
force-pushed
the
load-feature
branch
from
b203a46 to
9354cfa
Compare
For classloader and core features, add the feature to the collection of loaded features before performing the load to break endless recursion in the presence of cyclic dependencies.
|
Sounds good, this is already how the normal files are loaded, |
eregon
added a commit
that referenced
this pull request
Jul 28, 2015
[Truffle] Add to loadedFeatures before loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For classloader and core features, add the feature to the collection of
loaded features before performing the load to break endless recursion in
the presence of cyclic dependencies.
This brings the behavior of core and classloader features in line with file features. I am encountering a cyclic dependency when doing ahead of time compilation. Since I include all ruby files in the image, features that would have been resolved as files instead are found with the classloader.
A quick way to expose this issue is to add
require_relative 'core.rb'to truffle/src/main/ruby/core.rb.