Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PDLPorters/pdl
base: 3ca9250a44ac
Choose a base ref
...
head repository: PDLPorters/pdl
compare: 61955efcde9e
Choose a head ref
  • 10 commits
  • 3 files changed
  • 1 contributor

Commits on Jul 28, 2015

  1. test comparisons between scalars and 0-dim PDLs with badflag == 1 

    This is to elucidate the issues with stat() and per-PDL badvalues
brought up by Marek Gierliński in SF#390
<http://sourceforge.net/p/pdl/bugs/390/>,
<#124>.

When testing the scalar comparison, test across several values on either
side of bad value so that it is clear which case is failing.

The test must be skipped if BADVAL_USENAN: the test sets `badvalue()`.
    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    fbf5fdb View commit details
    Browse the repository at this point in the history

  2. fix name of variable used for op codegen Exception parameter 

    Also added a note that the parameter is unused because it is not
involved in setting `$badcode` for exceptional cases for each function
as intended (e.g., negative values for `sqrt()` would require complex
numbers to be returned).

This helps move PDL towards using `use strict` everywhere.
    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    77197ec View commit details
    Browse the repository at this point in the history

  3. clean up BadCode string for biop() codegen

    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    eb95695 View commit details
    Browse the repository at this point in the history

  4. change the conditional for checking for BAD values in biop() 

    When checking for badvalues in binary operators, we need to be sure that
each of the operands are not only badvalues, but also **have the badflag
set**. This way non-bad PDLs and scalars do not get treated as bad when
they are not.
    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    a687f5c View commit details
    Browse the repository at this point in the history

  5. check that the badflag is not set after calling stats()

    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    29b0193 View commit details
    Browse the repository at this point in the history

  6. add a test comparing a PDL with a badvalue with a Perl scalar

    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    cd89237 View commit details
    Browse the repository at this point in the history

  7. statsover() should not set the badflag unless all its inputs are bad 

    The documentation for `statsover()` states that it ignores badvalues.
Since `stats()` calls `statsover()`, this behaviour applies there as
well.
    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    f9d0e44 View commit details
    Browse the repository at this point in the history

  8. ensure that the badflag is set when statsover() has all badvalues

    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    68e993f View commit details
    Browse the repository at this point in the history

  9. more tests of badvalues with stats() and statsover() 

    Converted the older tests to be data-driven.
    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    ab1e97d View commit details
    Browse the repository at this point in the history

  10. throw a warning when using comparison operator and badval is in {0, 1} 

    When using a comparison operator, inconsistent results can appear when a
badvalue is either 0 or 1. This is because {0, 1} is the range of all
operators that return a logical PDL. This means that if the input PDL
contains badvalues, it can not both represent badvalues that are the
result of computing the operator *and* logical values at the same time.

This is a continuation of the work addressing the problem brought up in
<http://sourceforge.net/p/pdl/bugs/390/>, <#124>.
    @zmughal
    zmughal committed Jul 28, 2015
    Copy the full SHA
    61955ef View commit details
    Browse the repository at this point in the history