should fix issue where 'read on closed body' error was leaking down #1540
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
| // reading on a closed response body is as good as an io.EOF here | ||
| if err != nil && strings.Contains(err.Error(), "read on closed response body") { | ||
| err = io.EOF | ||
| } |
There was a problem hiding this comment.
@zignig was this what you were seeing? "read on closed response body"
|
@whyrusleeping this LGTM 👍 any known way to repro the error? (for a test case) |
|
LGTM but not to travis. looks like a lot of bad luck. rerunning |
jbenet
added a commit
that referenced
this pull request
Jul 29, 2015
should fix issue where 'read on closed body' error was leaking down
|
@jbenet yeah, i couldnt figure out how to get it to repro on my computer sadly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the issues seen here: https://travis-ci.org/ipfs/go-ipfs/jobs/73239014#L3661
I had special cased the error in one spot earlier where this error is always hit, but in cases where we pass the reader back directly, its a bit of a race on whether the final read happens before or after the body is closed. This embeds the error check into the reader wrapping the body so we always get that error checked properly and converted into an io.EOF
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com