-
-
Notifications
You must be signed in to change notification settings - Fork 925
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 21a9cbe3b8d5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1512d9afe870
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 3 commits
- 2 files changed
- 2 contributors
Commits on Jul 24, 2015
-
Define packages for classes in nested JARs
Packages are defined in the private `defineClass(String name, Resource res)` of `URLClassLoader`, which is only called from `findClass(final String name)`. Thus, whenever `findClass()` in `URLClassLoader` throws `ClassNotFoundException` (e.g. for JARs within JARs), the package doesn't get defined, even if `findClass(String className)` in `JRubyClassLoader` is able to find and define the sought class. I've used http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/java/net/URLClassLoader.java for reference.
Joel Segerlind committedJul 24, 2015 Configuration menu - View commit details
-
Copy full SHA for f77aea2 - Browse repository at this point
Copy the full SHA f77aea2View commit details -
Add test for packages of classes in nested JARs
The example would fail unless the package has been defined, as JavaClass#package would return nil, which obviously doesn't define the method #name.
Joel Segerlind committedJul 24, 2015 Configuration menu - View commit details
-
Copy full SHA for c0a9e8e - Browse repository at this point
Copy the full SHA c0a9e8eView commit details
Commits on Jul 25, 2015
-
Merge pull request #3160 from jowl/define-package-in-nested-jars
Define packages for classes in nested JARs
Configuration menu - View commit details
-
Copy full SHA for 1512d9a - Browse repository at this point
Copy the full SHA 1512d9aView commit details
There are no files selected for viewing