Skip to content

Commit

Permalink
Android: statically load iconv library
Browse files Browse the repository at this point in the history
Fixes #3291

Thanks to @arpruss for reporting the bug, and suggesting the fix.

Also, remove trailing whitespaces.
  • Loading branch information
est31 committed Oct 24, 2015
1 parent e46fa22 commit 49bda7f
Showing 1 changed file with 16 additions and 15 deletions.
31 changes: 16 additions & 15 deletions build/android/src/net/minetest/minetest/MtNativeActivity.java
Expand Up @@ -12,23 +12,23 @@ public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
m_MessagReturnCode = -1;
m_MessageReturnValue = "";

}

@Override
public void onDestroy() {
super.onDestroy();
}


public void copyAssets() {
Intent intent = new Intent(this, MinetestAssetCopy.class);
startActivity(intent);
}

public void showDialog(String acceptButton, String hint, String current,
int editType) {

Intent intent = new Intent(this, MinetestTextEntry.class);
Bundle params = new Bundle();
params.putString("acceptButton", acceptButton);
Expand All @@ -40,37 +40,37 @@ public void showDialog(String acceptButton, String hint, String current,
m_MessageReturnValue = "";
m_MessagReturnCode = -1;
}

public static native void putMessageBoxResult(String text);

/* ugly code to workaround putMessageBoxResult not beeing found */
public int getDialogState() {
return m_MessagReturnCode;
}

public String getDialogValue() {
m_MessagReturnCode = -1;
return m_MessageReturnValue;
}

public float getDensity() {
return getResources().getDisplayMetrics().density;
}

public int getDisplayWidth() {
return getResources().getDisplayMetrics().widthPixels;
}

public int getDisplayHeight() {
return getResources().getDisplayMetrics().heightPixels;
}

@Override
protected void onActivityResult(int requestCode, int resultCode,
Intent data) {
if (requestCode == 101) {
if (resultCode == RESULT_OK) {
String text = data.getStringExtra("text");
String text = data.getStringExtra("text");
m_MessagReturnCode = 0;
m_MessageReturnValue = text;
}
Expand All @@ -79,21 +79,22 @@ protected void onActivityResult(int requestCode, int resultCode,
}
}
}

static {
System.loadLibrary("openal");
System.loadLibrary("ogg");
System.loadLibrary("vorbis");
System.loadLibrary("ssl");
System.loadLibrary("crypto");
System.loadLibrary("gmp");
System.loadLibrary("iconv");

// We don't have to load libminetest.so ourselves,
// but if we do, we get nicer logcat errors when
// loading fails.
System.loadLibrary("minetest");
}

private int m_MessagReturnCode;
private String m_MessageReturnValue;
}

0 comments on commit 49bda7f

Please sign in to comment.