Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

[discuss] Switch to superagent instead of raw http.request #83

Closed

Conversation

dignifiedquire
Copy link
Contributor

@diasdavid Ref #69

Benefits

Changes

  • No support for vinyl currently

@victorb
Copy link
Contributor

victorb commented Oct 24, 2015

Would the usage always be like this? (Re res[0])

    ipfs.id(function (err, res) {
       if (err) throw err
       if (err) throw err
      var id = res[0]

In that case, I would suggest doing that before returning, so people wouldn't have to duplicate the grabbing of the first element of res in every single api call.

Also, we should probably have some tests at least to ensure src/request-api.js is working as expected.

@dignifiedquire
Copy link
Contributor Author

@victorbjelkholm that is only temporary, the res[0] is very annoying atm but wanted to get sth up to see if it works as expected.

Re tests for request-api itself, I think when we have the tests from #81 we should be fine

@dignifiedquire
Copy link
Contributor Author

@victorbjelkholm fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants