Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix streaming output to flush per write #1882

Merged
merged 2 commits into from
Oct 27, 2015
Merged

fix streaming output to flush per write #1882

merged 2 commits into from
Oct 27, 2015

Conversation

whyrusleeping
Copy link
Member

after the refactor to use go1.5 trailers the http lib started buffering output, so commands like ipfs ping and ipfs stats bw --poll would either print all at the end, or wait until the buffer filled to print.

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@jbenet jbenet added the status/in-progress In progress label Oct 21, 2015
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@cryptix
Copy link
Contributor

cryptix commented Oct 23, 2015

LGTM

@jbenet
Copy link
Member

jbenet commented Oct 27, 2015

LGTM, thanks for fixing.

jbenet added a commit that referenced this pull request Oct 27, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix streaming output to flush per write
@jbenet jbenet merged commit 356c353 into master Oct 27, 2015
@jbenet jbenet deleted the fix/streaming-output branch October 27, 2015 05:33
@whyrusleeping whyrusleeping mentioned this pull request Nov 2, 2015
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants