-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add systemd unit to misc/ #1864
Conversation
License: MIT Signed-off-by: kpcyrd <git@rxv.cc>
Would this start ipfs daemon as root? |
@ion1 this is supposed to be used with There's no sane way to drop privileges for ipfs inside the unit file. |
@kpcyrd could you add a small readme, or installation instructions for the service? It looks good to me otherwise. |
License: MIT Signed-off-by: kpcyrd <git@rxv.cc>
This is based on the work of github.com/ipfs/examples/init/ License: MIT Signed-off-by: kpcyrd <git@rxv.cc>
|
(so, no i dont think we should merge this) |
@jbenet the reasoning here is that it make it easier on package managers to set up their package builds if everything needed for the install is in one repo. Although if you're against merging this then we should make a working init script and put it in the examples repo you linked. |
sure, we should maybe have a repo with all the various init scripts and point there from this repo. |
A second repo would break the workflow of packaging. go-ipfs made it into the arch community repo, they maintain a copy of ipfs.service in their repo now. |
i agree with @kpcyrd here, i think that everything needed for an 'installation' of go-ipfs should be in the same repo, if we ship bash completions in the misc folder, why not also have various init scripts there too? |
+1 to including init scripts directly in the repository. |
This repo will eventually be broken apart into a bunch of smaller repos. and, another repo (or perhaps it will be this one, if that is its future) will pull in (from other repos) the pieces necessary to build and sign a full release. inc building artifacts like various platform installers. thus clean separation of concerns. Also, i will not start dictating what this repo does based on what any package manager needs. theres tons of them and it will be a nightmare to try and please everybody. it is TRIVIAL to make another repo, pull this one in as a submodule and make any desired changes / file additions. This is a much better and more scalable approach as it allows all the package managers / platforms to do whatever they need to do, control the entire thing, and without conflicting with us or each other at all. (so maybe go make
i've been wanting to remove those, and the random bins too. they should not crowd this repo, and they should have their own clean, simple version control. We can trivially link to those repos, and provide installation of the tools via ipfs itself. i've been wanting for some time, and i plan to make soon, a "toolchain" that is shipped via ipfs itself and can be installed (individually, or together) -- this toolchain will include things like
|
closing based on comments above. |
Distros started shipping their own ipfs.service now, you have to coordinate with downstream if there are any changes you want to make. |
License: MIT
Signed-off-by: kpcyrd git@rxv.cc