log exception backtrace in one log record #3403
Merged
+49
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opposed to len+1
before:
```
2015-10-20T11:41:37.415+02:00: TraceType: Backtrace generated:
2015-10-20T11:41:37.415+02:00: TraceType: uncaugh_exception.rb:20 in push
2015-10-20T11:41:37.415+02:00: TraceType: uncaugh_exception.rb:28 in push_to_queue
2015-10-20T11:41:37.415+02:00: TraceType: uncaugh_exception.rb:38 in (root)
```
after :
```
2015-10-20T12:31:04.682+02:00: TraceType: Backtrace generated:
push at uncaugh_exception.rb:20
push_to_queue at uncaugh_exception.rb:28
(root) at uncaugh_exception.rb:38
```
kares
added a commit
that referenced
this pull request
Dec 4, 2015
log exception backtrace in one log record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jruby -Xlog.backtraces=true ...currently logs backtraces in multiple log records,this can easily become an issue e.g. when multiple threads are logging backtraces at the same time.
this PR fixes the logging to produce one multi-line log item per backtrace and to use the JRuby format. seems that it could be useful for JRuby 1.7.x but in case of compatibility worries, I'm happy to target 9K only.