add prefix check before update properties #921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -436,6 +436,19 @@ public void updateProperties(final IdentifierConverter<Resource, FedoraResource> | |||
|
|
|||
| final Collection<IllegalArgumentException> errors = checkInvalidPredicates(request); | |||
|
|
|||
| request.getPrefixMapping().getNsPrefixMap().forEach( | |||
| (k,v) -> { try { | |||
| LOGGER.info("451: prefix mapping is key -> value: " + k + "->" + v + "\n"); | |||
There was a problem hiding this comment.
Comments on your logging:
- When using slf4j (which you are), you should take advantage of templating. For example, the above line should be:
LOGGER.info("451: prefix mapping is key -> value: {} -> {}", k, v); - This should be
debugnotinfo - Please remove
451:, unless I am missing its purpose.
There was a problem hiding this comment.
That better not be a reference to HTTP 451.
|
Please create an integration test that demonstrates the issue before your functional updates, and proves the fix after your functional updates. |
| /** | ||
| * For invalid namespace exceptions on CRUD actions for nodes/datastreams | ||
| * | ||
| * @author whikloj |
|
Resolved with: 8057124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have time to create new type exception. Also I would prefer some design this first like naming...