Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: fix description of --api #1866

Merged
merged 1 commit into from
Nov 30, 2015
Merged

commands: fix description of --api #1866

merged 1 commit into from
Nov 30, 2015

Conversation

ghost
Copy link

@ghost ghost commented Oct 19, 2015

This was probably overlooked after copy-pasting.

@GitCop
Copy link

GitCop commented Oct 19, 2015

There were the following issues with your Pull Request

  • Commit: 0ad22a5
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

@jbenet jbenet added the status/in-progress In progress label Oct 19, 2015
@ghost
Copy link
Author

ghost commented Oct 19, 2015

Sorry, forgot that commits through Github's UI don't add the DCO

@ghost ghost force-pushed the lgierth-patch-1 branch from 0ad22a5 to 3d4a5ac Compare October 19, 2015 23:16
@whyrusleeping
Copy link
Member

Schweet. LGTM

@whyrusleeping whyrusleeping added RFM and removed status/in-progress In progress labels Oct 20, 2015
@whyrusleeping
Copy link
Member

@jbenet 👍 ?

@cryptix
Copy link
Contributor

cryptix commented Oct 28, 2015

Is this in legacy format, not multiaddr?

@whyrusleeping
Copy link
Member

@cryptix oh, huh. good catch, the code takes a multiaddr.

@ghost
Copy link
Author

ghost commented Oct 28, 2015

Oh yep :/ Will fix

@ghost ghost removed the RFM label Oct 28, 2015
@ghost ghost self-assigned this Oct 28, 2015
@jbenet
Copy link
Member

jbenet commented Nov 2, 2015

wish github made these types of changes easier

@RichardLitt RichardLitt mentioned this pull request Nov 2, 2015
47 tasks
@ghost ghost force-pushed the lgierth-patch-1 branch from 3d4a5ac to 9ffe12b Compare November 2, 2015 17:13
@ghost ghost added the RFM label Nov 3, 2015
@whyrusleeping
Copy link
Member

LGTM, @lgierth rebase?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
@ghost ghost force-pushed the lgierth-patch-1 branch from 9ffe12b to ebf9511 Compare November 23, 2015 19:35
@ghost
Copy link
Author

ghost commented Nov 23, 2015

rebased

jbenet added a commit that referenced this pull request Nov 30, 2015
commands: fix description of --api
@jbenet jbenet merged commit 792da9d into master Nov 30, 2015
@jbenet jbenet deleted the lgierth-patch-1 branch November 30, 2015 08:40
@jbenet
Copy link
Member

jbenet commented Nov 30, 2015

these spurious failures are so annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants