Revert .consolerc (sorry, @andremediros :grimace:)

Rather than adding .consolerc and seeing the surface area of things that Bundler supports continue to grow endlessly, Bundler 2.0 will deprecate the `bundle console` command, and instead add a script to each generated gem that loads `bundler/setup` and then loads the gem. Anyone can then edit that file to run the REPL they want, load the fixtures they want, and everything else, without anything specific to Bundler at all.
rubygems · Jan 26, 2015 · 748d8ec · 748d8ec · andremedeiros · Jan 26, 2015
1 parent 3f4a1ff
commit 748d8ec
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,6 @@ Features:
   - add support for private S3 sources (@tryba)
   - prevent whitespace in gem declarations with clear messaging (@benlakey)
   - tries to find a `bundler-<command>` executable on your path for non-bundler commands (@andremedeiros)
-  - generates a `.consolerc` file with new gems and tries to load it on `bundle console` (@andremedeiros)
   - tries to find `gems.rb` and it's new counterpart, `gems.locked` (@andremedeiros)
   - Change the initial version of new gems from `0.0.1` to `0.1.0` (@petedmarsh)
 

diff --git a/lib/bundler/cli/console.rb b/lib/bundler/cli/console.rb
@@ -11,7 +11,6 @@ def run
       ARGV.clear
 
       console = get_console(Bundler.settings[:console] || 'irb')
-      load '.consolerc' if File.exists?('.consolerc')
       console.start
     end
 

diff --git a/lib/bundler/cli/gem.rb b/lib/bundler/cli/gem.rb
@@ -44,7 +44,6 @@ def run
         "lib/newgem/version.rb.tt" => "lib/#{namespaced_path}/version.rb",
         "LICENSE.txt.tt" => "LICENSE.txt",
         "newgem.gemspec.tt" => "#{name}.gemspec",
-        "consolerc.tt" => ".consolerc",
         "Rakefile.tt" => "Rakefile",
         "README.md.tt" => "README.md"
       }

diff --git a/lib/bundler/templates/newgem/consolerc.tt b/lib/bundler/templates/newgem/consolerc.tt
diff --git a/spec/commands/console_spec.rb b/spec/commands/console_spec.rb
@@ -39,14 +39,6 @@
     expect(out).to include("IRB")
   end
 
-  it "loads up .consolerc if it exists" do
-    consolerc <<-C
-      puts "Hello!"
-    C
-    bundle "console"
-    expect(out).to include("Hello!")
-  end
-
   it "doesn't load any other groups" do
     bundle "console" do |input|
       input.puts("puts ACTIVESUPPORT")

diff --git a/spec/commands/newgem_spec.rb b/spec/commands/newgem_spec.rb
@@ -90,7 +90,6 @@ def create_temporary_dir(dir)
       expect(bundled_app("test_gem/lib/test_gem.rb")).to exist
       expect(bundled_app("test_gem/lib/test_gem/version.rb")).to exist
       expect(bundled_app("test_gem/.gitignore")).to exist
-      expect(bundled_app("test_gem/.consolerc")).to exist
     end
 
     it "starts with version 0.1.0" do

diff --git a/spec/support/helpers.rb b/spec/support/helpers.rb
@@ -165,10 +165,6 @@ def lockfile(*args)
       create_file("Gemfile.lock", *args)
     end
 
-    def consolerc(*args)
-      create_file(".consolerc", *args)
-    end
-
     def strip_whitespace(str)
       # Trim the leading spaces
       spaces = str[/\A\s+/, 0] || ""