update max metaspace size #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -539,7 +539,7 @@ | |||
| <plugin> | |||
| <artifactId>maven-failsafe-plugin</artifactId> | |||
| <configuration> | |||
| <argLine>-XX:MaxMetaspaceSize=128m ${jacoco.agent.it.arg}</argLine> | |||
| <argLine>-XX:MaxMetaspaceSize=512m ${jacoco.agent.it.arg}</argLine> | |||
There was a problem hiding this comment.
The last time I wanted to up the memory for failsafe, @fasseg was of the vociferous opinion that it wold be difficult for people to build Fedora with a half-gig for tests. I disagreed, but we left it alone then. You might want to ping the -tech list letting them know this is happening, in case anyone wants to react.
There was a problem hiding this comment.
I picked 512m because that's the value currently in use for the (surefire) unit tests: see line 561 below. That is, unless I'm misreading this, it seems fcrepo already requires .5 GB for the tests (and has for some time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://jira.duraspace.org/browse/FCREPO-1796