Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f13084b7c10f
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d281884824fa
Choose a head ref
  • 8 commits
  • 5 files changed
  • 1 contributor

Commits on Nov 5, 2014

  1. Add back synchronization around IO methods that touch the file. 

    Part of fixes for #2102.
    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    7b4d45e View commit details

  2. Bit of RubyIO cleanup.

    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    0308b80 View commit details

  3. Only query realFileno once here.

    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    4f79ed3 View commit details

  4. Clean up uses of old select logic.

    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    4a6e40c View commit details

  5. Fix select logic to only "ready" fds with appropriate operations. 

    POSIX select removes from the given fd sets all fds that are *not*
ready for that particular operation. That was missing in our
logic, so *all* fds selected on were put into *all* ready lists.

This change passes a set of interest operations into fdIsSet,
allowing us to detect whether the fd is actually ready for the
requested operations.

For #2102.
    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    feb9757 View commit details

  6. Deprecate SelectBlob.

    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    0017c8c View commit details

  7. Clean up imports.

    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    8abdf4f View commit details

  8. Ensure fd doesn't null out on us halfway through.

    @headius
    headius committed Nov 5, 2014
    Copy the full SHA
    d281884 View commit details
Loading