Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made memory calculation a lot less hardcoded, finally allowing addons to define custom memory types. #1733

Merged

Conversation

Vexatos
Copy link
Contributor

@Vexatos Vexatos commented Apr 2, 2016

This is an important change for addons adding custom architectures as it changes the default values of OC Memory. It allows for addons to add their own types of memory in the Lua architecture. No longer is it hardcoded to the six values specified in the config file as those are used by the Memory instance itself now instead of the architecture, also making other architectures benefit from the config option. Furthermore, the memory calculated has been clamped between 0 and 50 MB (still a lot) to avoid integer overflows in case the config settings are too high.

@fnuecke fnuecke merged commit 8e54d5e into MightyPirates:master-MC1.7.10 Apr 5, 2016
@Vexatos Vexatos deleted the architecture-memory-fix branch December 11, 2016 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants