Made memory calculation a lot less hardcoded, finally allowing addons to define custom memory types. #1733
+12
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an important change for addons adding custom architectures as it changes the default values of OC Memory. It allows for addons to add their own types of memory in the Lua architecture. No longer is it hardcoded to the six values specified in the config file as those are used by the Memory instance itself now instead of the architecture, also making other architectures benefit from the config option. Furthermore, the memory calculated has been clamped between 0 and 50 MB (still a lot) to avoid integer overflows in case the config settings are too high.